Maniphest T119261

While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Nov 20 2015, 11:51 PM

Description

When I try to resize a graph using resize handler I seem to cant reduce it below 60x60 px but from the dialog it can go below that. Shouldnt they be same?

Screen Shot 2015-11-20 at 3.51.35 PM.png (162×490 px, 14 KB)

Details

	Subject	Repo	Branch	Lines +/-
	VE: Use MediaSizeWidget with restricted dimensions	mediawiki/extensions/Graph	master	+41 -36

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• ferdbold	T119233 [Objective] It's easier to create and edit charts from within VisualEditor
Resolved	Esanders	T119261 While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog
Resolved	Esanders	T120653 Allow ve.ui.MediaSizeWidget to take a plain dimensions widget

Event Timeline

Ryasmeen created this task.Nov 20 2015, 11:51 PM

Ryasmeen raised the priority of this task from to Needs Triage.

Ryasmeen updated the task description. (Show Details)

Ryasmeen added a project: VisualEditor.

Ryasmeen added subscribers: Ryasmeen, • ferdbold.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 20 2015, 11:51 PM

Ryasmeen added a project: Graph-VisualEditor.Nov 20 2015, 11:57 PM

Ryasmeen set Security to None.

Yeah me and @Esanders noticed that as well, that's because OO.ui.DimensionsWidget doesn't account for resizable nodes when it probably should.

Jdforrester-WMF renamed this task from While using the resize handler the lowest limit for resizing a graph is 60x60px but not when resizing from dialog to While using the resize handler on a graph, the lowest limit for resizing is 60x60px, but not when resizing from dialog.Nov 24 2015, 8:21 PM

Jdforrester-WMF assigned this task to • ferdbold.

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

• ferdbold added a project: MediaWiki-extensions-Graph.Dec 3 2015, 5:04 AM

• ferdbold moved this task from Backlog to VisualEditor on the MediaWiki-extensions-Graph board.

Jdforrester-WMF added a parent task: T118898: "TypeError: can't convert undefined to object" apperas when I delete all the co-ordinates from Data section of the Graph editor and cannot open any other inspector after that.Dec 3 2015, 6:12 PM

Jdforrester-WMF removed a parent task: T118898: "TypeError: can't convert undefined to object" apperas when I delete all the co-ordinates from Data section of the Graph editor and cannot open any other inspector after that.

Jdforrester-WMF added a parent task: T119233: [Objective] It's easier to create and edit charts from within VisualEditor.

Esanders added a subtask: T120653: Allow ve.ui.MediaSizeWidget to take a plain dimensions widget.Dec 7 2015, 1:09 PM

Change 257319 had a related patch set uploaded (by Esanders):
VE: Use MediaSizeWidget with restricted dimensions

https://gerrit.wikimedia.org/r/257319

gerritbot added a project: Patch-For-Review.Dec 7 2015, 2:15 PM

Jdforrester-WMF closed subtask T120653: Allow ve.ui.MediaSizeWidget to take a plain dimensions widget as Resolved.Dec 7 2015, 4:46 PM

Jdforrester-WMF closed this task as Resolved.Dec 7 2015, 7:17 PM

Jdforrester-WMF reassigned this task from • ferdbold to Esanders.

Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)); removed Patch-For-Review.

Change 257319 merged by jenkins-bot:
VE: Use MediaSizeWidget with restricted dimensions