Page MenuHomePhabricator

Extension or User based elements added to the default WikiEditor toolbar are not loaded in certain namespaces and/or instances
Open, Needs TriagePublic

Description

Example: https://nl.wikisource.org/w/index.php?title=Pagina:Noorsche_Volksvertellingen.djvu/59&action=edit

Another series of yet to be created pages displaying the same drop out of post defer loaded buttons and or booklets in the Page: namespace found here:

Event Timeline

Tpt raised the priority of this task from to Needs Triage.
Tpt updated the task description. (Show Details)
Tpt added projects: Wikisource, ProofreadPage.
Tpt added subscribers: Aklapper, StudiesWorld, Tpt.

Seems to happen the first time you land on a Page: that hasn't been created yet.


For me: clicking on the following (with or without &redlink=1) always rendered without the Proofreading Tools menu initially ...

... subsequent "refreshes" after that initial click-in brings back the expected rendering behavior.


But if I first navigated there by using this...

... and then selected the create/edit tab or clicked the link in the edit banner content itself, the PR tools menu is always generated on the first attempt to open an edit (create) session.

Runing....

... did not change anything either.

I also noticed that it takes an eternity during 'opening an edit session' for it to switch to my user preference selected horizontal view from the default side-by-side view (load order? dependencies?).

Fwiw... I am getting a half dozen console alerts about deprecated scripting calls to boot.

I don't know if this is relevant but I couldn't help to notice that (at least for me; Win10 Edge1511) the "menu tab" for PR tools is the last tab generated html wise but it's corresponding "hidden until selected menu" is generated 2nd then somehow rendered 4th.
Hopefully the following helps to illustrate what I'm "seeing"...

<div class="tabs">
	<span class="tab tab-advanced" rel="advanced">
		<a role="button" aria-pressed="false" aria-controls="wikiEditor-section-advanced" href="#">Advanced</a>
	</span>
	<span class="tab tab-characters" rel="characters">
		<a role="button" aria-pressed="false" aria-controls="wikiEditor-section-characters" href="#">Special characters</a>
	</span>
	<span class="tab tab-help" rel="help">
		<a role="button" aria-pressed="false" aria-controls="wikiEditor-section-help" href="#">Help</a>
	</span>
	<span class="tab tab-proofreadpage-tools" rel="proofreadpage-tools"><!--
HERE-->		<a role="button" aria-pressed="false" aria-controls="wikiEditor-section-proofreadpage-tools" href="#">Proofread tools</a>
	</span>
</div>
<div class="sections">
	<div class="toolbar section section-advanced section-hidden" id="wikiEditor-section-advanced" aria-expanded="false" rel="advanced">
		<div class="group group-heading" rel="heading"><!-- snipped content --></div>
	</div><!--
HERE-->	<div class="toolbar section section-proofreadpage-tools section-hidden" id="wikiEditor-section-proofreadpage-tools" aria-expanded="false" rel="proofreadpage-tools">
		<div class="group group-zoom" rel="zoom"><!-- snipped content --></div>
		<div class="group group-other" rel="other"><!-- snipped content --></div>
	</div>
	<div class="booklet section section-characters section-hidden" id="wikiEditor-section-characters" aria-expanded="false" rel="characters">
		<div class="index"><!-- snipped content --></div>
	</div>
	<div class="booklet section section-help section-hidden" id="wikiEditor-section-help" aria-expanded="false" rel="help">
		<div class="index"><!-- snipped content --></div>
	</div>
</div>

I'm pretty sure the "menu tab" and its corresponding "menu" are best when aligned to the same position (either both 2nd after the Advanced pair OR both last after the Help pair). @Tpt?

Dear Friends,
this is not only a problem on nl-wikisource. Most of the time I can't use the "Proofread tools"-bar on en-wikisource either. Every now and then it pops up, but after a few edits it disappears again, and it does not come back. This is really nasty. It makes the proofreading difficult / impossible. So please, help us! Greetings, --~~~~

Until the issue is resolve, you can try the old toolbar.

GOIII renamed this task from The "Proofread tools" section of the WikiEditor toolbar is sometime not loaded on nl.wikisource Page: pages to Extension or User based elements added to the default WikiEditor toolbar are not loaded in certain namespaces and/or instances.Feb 27 2016, 5:16 AM
GOIII added a project: WikiEditor.
GOIII updated the task description. (Show Details)
GOIII added subscribers: AlexMonk-WMF, Fomafix, TheDJ.

Another series of yet to be created pages displaying the same drop out of post defer loaded buttons and or booklets:

https://test2.wikipedia.org/wiki/Page:Champollion_-_Lettres_%C3%A9crites_d%E2%80%99%C3%89gypte_et_de_Nubie_en_1828_et_1829.djvu/200

I suspect this and similar long standing issues with extension added toolbars (like the Proofread Page tools) and/or User: added buttons (OCR tool) stem from the deferred loading of booklets as described in T126128 among others.

Is there any way to see if the elimination (or disabling?) the defer bits resolves this vein of loading issues?

It has nothing to do with deferred loading of buttons. It's because of asynchronous execution and Pageread javascript that needs some serious rewriting..

The fact that sometimes the image of a book is outside the entire wikieditor is another signal of this problem.

It has nothing to do with deferred loading of buttons. It's because of asynchronous execution and Pageread javascript that needs some serious rewriting..

While I can't disagree or agree about the role that asynchronous execution and the need for an overhaul of the PR extension might play here, I still beg to differ when it comes specifically to the "nuance" of booklets.

A booklet has an index (or label) on the left and an associated page of content related to that index to the right when that type of tab is selected in WikiEditor. Examples of a booklet are the 'Special character' and 'Help' tabs in WikiEditor.

The only "type" of WikiEditor component that I know of that accepts the deferLoad= parameter are booklets not buttons or groups of buttons (like the 'Advanced' tab is).

Its this deferred loading of booklets that prevents manipulation of the contents of the existing booklets using 'removeFromToolbar' as [prematurely closed out in?] T70791 described.

So adding additional buttons that insert tags or implement formatting is not the major issue but customizing entire language/character sets [not so much individual characters] and help snippets per wiki project are.

The claim that "older windows" users would rather have speedy access to crap they'll barely use is pretty lame when given the ability to customize those booklets is what is really needed/wanted from my experience.

The fact that sometimes the image of a book is outside the entire wikieditor is another signal of this problem.

Fwiw... I've never seen this. The book thumbnail is always within one of the containers within WikiEditor's design as far as the Page: namespace goes of Wikisource.