Page MenuHomePhabricator
Create Task
Maniphest T119486

Brief FOUC before the search icon is rendered
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

This happened when the search submit button was changed to be a search icon.

It is using the <img> tag so the image is rendered a few ms later and meanwhile the button is empty.
When the image is rendered, the button width increases so the dropdown + the input slightly move to the left.

Thanks to @ori for the video:

fouc_portal.mov391 KBDownload

Details

SubjectRepoBranchLines +/-
Brief FOUC before the search icon is renderedwikimedia/portalsmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JGirault created this task.Nov 24 2015, 6:00 AM
• JGirault raised the priority of this task from to Needs Triage.
• JGirault updated the task description. (Show Details)
• JGirault added projects: Discovery-ARCHIVED, Discovery-Portal-Sprint.
• JGirault added subscribers: • JGirault, ori.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 24 2015, 6:00 AM
Jdrewniak set Security to None.Dec 8 2015, 10:28 PM
Jdrewniak edited a custom field.
• Deskana merged a task: T121844: FOUC on https://www.wikipedia.org/.Dec 23 2015, 5:05 AM
• Deskana added a subscriber: Glaisher.
• Deskana triaged this task as Medium priority.Dec 29 2015, 10:07 PM
• Deskana moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.
• Deskana subscribed.
debt moved this task from Backlog to What's Next on the Discovery-Portal-Sprint board.Jan 26 2016, 12:46 AM
debt assigned this task to Jdrewniak.Jan 26 2016, 7:51 PM
debt moved this task from What's Next to In Progress on the Discovery-Portal-Sprint board.
Jdrewniak added a comment.Jan 27 2016, 10:57 AM
This comment was removed by Jdrewniak.
gerritbot subscribed.Jan 27 2016, 10:57 AM

Change 266677 had a related patch set uploaded (by Jdrewniak):
Brief FOUC before the search icon is rendered

https://gerrit.wikimedia.org/r/266677

gerritbot added a project: Patch-For-Review.Jan 27 2016, 10:57 AM
Jdrewniak moved this task from In Progress to Needs code review on the Discovery-Portal-Sprint board.Jan 27 2016, 11:06 AM
gerritbot added a comment.Jan 27 2016, 10:19 PM

Change 266677 merged by jenkins-bot:
Brief FOUC before the search icon is rendered

https://gerrit.wikimedia.org/r/266677

• JGirault added a parent task: T124993: EPIC: Next deployment of portal page to production (bug fixes, remove inline JS).Jan 27 2016, 10:37 PM
• JGirault moved this task from Needs code review to Done on the Discovery-Portal-Sprint board.
debt closed this task as Resolved.Jan 27 2016, 11:25 PM
• JGirault added a parent task: T125100: Merge into Master and deploy to Beta Portal.Jan 28 2016, 11:13 PM
debt moved this task from Done to Completed on the Discovery-Portal-Sprint board.Feb 4 2016, 11:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits