During the preview, the custom parser tag <graph> needs to generate different HTML than during the save. It seems that the $parser->getOptions()->getIsPreview() is almost meaningless, as parser reuses previous parsing result even if it was done in preview mode. Is there an option to indicate that preview parsing is not valid for the final result?
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fixed preview caching polluting parser cache | mediawiki/extensions/Graph | master | +8 -4 |
Related Objects
Related Objects
- Mentioned In
- T113189: Document ApiStashEdit
- Mentioned Here
- T119043: Graph/Graphoid/Kartographer - data storage architecture
Event Timeline
Comment Actions
Hmm, not entirely sure how this works, but with ParserOutput's recordOption, you should be able to introduce additional cache variance. includes/content/MessageContent.php does this for instance.
Comment Actions
ParserOutput->mAccessedOptions has been added by https://www.mediawiki.org/wiki/Special:Code/MediaWiki/70783
I haven't played with the Parser in ages but varying output based on preview would do it, though you would only want to vary when the graph tag got used.
Comment Actions
The vary-revision flag would probably also force the behaviour you want, although using it for this case is kind of hacky.
The parser should probably keep track of if isPreview is called, and if it is not reuse that particular paserOutput if is.
r
Comment Actions
What is the difference between the preview and save output? Can fragmentation be avoided by post-processing?
Comment Actions
Change 263039 had a related patch set uploaded (by Yurik):
Fixed preview caching polluting parser cache