Page MenuHomePhabricator
Create Task
Maniphest T120847

Use BCP 47 conform language codes for the HTML attribute lang
Closed, ResolvedPublic
Actions

Description

The value of the HTML attribute [[ https://www.w3.org/TR/html5/dom.html#the-lang-and-xmllang-attributes | lang ]] must be a valid BCP 47 language tag.

The HTML validation fails because of invalid language codes: https://validator.w3.org/nu/?doc=https://www.wikidata.org/wiki/Q5296

Details

SubjectRepoBranchLines +/-
Ensure LanguageCode::bcp47() returns a valid BCP 47 language codemediawiki/coremaster+212 -27
Ensure LanguageCode::bcp47() returns a valid BCP 47 language codemediawiki/coremaster+213 -27
Apply LanguageCode::bcp47 for lang and hreflang attributesmediawiki/extensions/Wikibasemaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Fomafix created this task.Dec 8 2015, 5:57 PM
Fomafix raised the priority of this task from to Low.
Fomafix updated the task description. (Show Details)
Fomafix added projects: Wikidata, MediaWiki-extensions-WikibaseView, MediaWiki-extensions-WikibaseRepository.
Fomafix subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2015, 5:57 PM
Lydia_Pintscher closed this task as Declined.Feb 7 2018, 4:09 PM
Lydia_Pintscher subscribed.

Realistically it seems we're not getting to it since it hasn't been touched in two years. Sorry :( Feel free to reopen with a patch.

Fomafix reopened this task as Open.Feb 7 2018, 4:32 PM
Fomafix updated the task description. (Show Details)
Fomafix added a parent task: T2209: [DO NOT USE] HTML validity (tracking).

Reopened. The HTML fails the HTML validation because of invalid lang attributes. This is not an invalid bug.

Fomafix updated the task description. (Show Details)Feb 7 2018, 4:38 PM
Fomafix added a comment.Apr 1 2018, 9:08 AM

T106367 is a related task for other lang attributes in MediaWiki core.

Krinkle removed a parent task: T2209: [DO NOT USE] HTML validity (tracking).Apr 20 2018, 4:15 PM
cscott subscribed.Jun 29 2018, 4:50 PM

There's a patch for proper BCP-47 validity conversion in core: I807dd55d49e9bd19443329231326a5b0d3e6c453

gerritbot subscribed.Jun 29 2018, 6:38 PM

Change 442200 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Ensure LanguageCode::bcp47() returns a valid BCP-47 language code

https://gerrit.wikimedia.org/r/442200

gerritbot added a project: Patch-For-Review.Jun 29 2018, 6:38 PM
Jdforrester-WMF mentioned this in T197009: MCS should respect Accept-Language header for MW API requests.Jul 13 2018, 6:00 PM
gerritbot added a comment.Jul 13 2018, 7:28 PM

Change 442200 merged by jenkins-bot:
[mediawiki/core@master] Ensure LanguageCode::bcp47() returns a valid BCP 47 language code

https://gerrit.wikimedia.org/r/442200

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 13 2018, 8:00 PM
Jdforrester-WMF closed this task as Resolved.Jul 14 2018, 1:26 AM
Jdforrester-WMF assigned this task to cscott.
Jdforrester-WMF subscribed.

Now fixed in Beta Cluster Wikidata: https://validator.w3.org/nu/?doc=https%3A%2F%2Fwikidata.beta.wmflabs.org%2Fwiki%2FQ470764

Remaining error is for the wikibase-aliasesview-list UL's dir being set to ''; not sure if that's filed?

Fomafix reopened this task as Open.Jul 20 2018, 10:35 AM

Reopened. Validation of https://www.wikidata.org/wiki/Q5296 (https://validator.w3.org/nu/?doc=https://www.wikidata.org/wiki/Q5296) still fails because for the lang and the hreflang attributes LanguageCode::bcp47 is not applied.

gerritbot added a comment.Jul 20 2018, 10:35 AM

Change 447054 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/Wikibase@master] Apply Language::bcp47 for lang and hreflang attributes

https://gerrit.wikimedia.org/r/447054

gerritbot added a comment.Sep 12 2018, 3:32 PM

Change 460038 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Ensure LanguageCode::bcp47() returns a valid BCP 47 language code

https://gerrit.wikimedia.org/r/460038

gerritbot added a comment.Oct 11 2018, 1:07 PM

Change 447054 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Apply LanguageCode::bcp47 for lang and hreflang attributes

https://gerrit.wikimedia.org/r/447054

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Oct 11 2018, 2:00 PM
gerritbot added a comment.Oct 11 2018, 8:46 PM

Change 460038 merged by jenkins-bot:
[mediawiki/core@master] Ensure LanguageCode::bcp47() returns a valid BCP 47 language code

https://gerrit.wikimedia.org/r/460038

Jdforrester-WMF removed a project: Patch-For-Review.Oct 11 2018, 9:10 PM
Fomafix closed this task as Resolved.Oct 19 2018, 1:31 PM

https://validator.w3.org/nu/?doc=https://www.wikidata.org/wiki/Q5296 reports no problem anymore.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits