Page MenuHomePhabricator

Generalize how RecentChanges flags are rolled up, to better support flags added by extensions
Closed, ResolvedPublic

Description

Currently, only the built-in Recent Changes flags will be rolled up into the collapsed row that contains a volley of changes. Flags implemented by extensions are not rolled up.

Generalize how the rollup happens so that all flags are treated equally. Abstract the idea of "true if any item is true" vs. "only true if all items are true" and annotate existing RC flags with "any" or "all".

Event Timeline

awight created this task.Dec 9 2015, 9:50 AM
awight updated the task description. (Show Details)
awight raised the priority of this task from to Normal.
awight claimed this task.
awight added subscribers: Legoktm, Halfak, Ladsgroup and 3 others.

Change 247249 had a related patch set uploaded (by Awight):
Generalize recentChangesFlags rollup

https://gerrit.wikimedia.org/r/247249

Change 247248 had a related patch set uploaded (by Awight):
Use template to render EnhancedChangesList groups

https://gerrit.wikimedia.org/r/247248

Change 247247 had a related patch set uploaded (by Awight):
Clean up recentChangesFlags rollups

https://gerrit.wikimedia.org/r/247247

Change 247247 merged by jenkins-bot:
Clean up recentChangesFlags rollups

https://gerrit.wikimedia.org/r/247247

Change 247248 merged by jenkins-bot:
Use template to render EnhancedChangesList groups

https://gerrit.wikimedia.org/r/247248

awight moved this task from Done to Review on the Scoring-platform-team (Current) board.

The only thing needed here is patch. @awight: do you have some time to check?

Change 247249 merged by jenkins-bot:
Generalize recentChangesFlags rollup

https://gerrit.wikimedia.org/r/247249

Jdforrester-WMF closed this task as Resolved.Apr 17 2016, 5:23 PM