@aaron can I add you to this task.

Also reported here on https://www.mediawiki.org/w/index.php?title=Topic:Sf6zgc7plebtit4v&topic_showPostId=sf6zgcpgrzr7uw75#flow-post-sf6zgcpgrzr7uw75 forum.

@Legoktm could I add you to the task.

Neeed help to replace the removed function since that means this extension.

@Paladox: It was removed in 1.24 which was released years ago. Why has this suddenly become urgent? ("Something was removed" is not a generic reason for high priority, especially not if it wasn't used too much.)
@Paladox: Did Aaron explicitly agree on being CC'ed here?

@Aklapper nope and because I think this may be the reason why it isent correctly saving or deleting it in the images folder.

I studied this extension and this bug. The original bug was fixed in almost all supported MW version (only 1.26 is missing). The description suggests changing $wgFileStore but this is unrelated to the actual bug (so possibly a new issue should be opened).

About the actual error described in the description

The error failed to mkdir "/accountcreds/p/pa/pal" was solved with https://gerrit.wikimedia.org/r/#/c/258373/, closing this bug: when the extension is activated with require_once before $wgUploadDirectory is set, the resulting directory is "/accountcreds" and only the root user can create this directory (which is aside /bin, /etc, etc.), so the solution was to differ the evaluation of this parameter using wgExtensionFunctions.

Hence this bug is solved in the following currently-supported environments (tested by myself):

• MW 1.23: no bug when using the extension branch REL1_23
• MW 1.26: bug: extension branches REL1_27 and master cannot be used because they call a newer MW function (ObjectCache::getLocalClusterInstance), REL1_26 doesn’t contain the fix
• MW 1.27: no bug when using the extension branches REL1_27 and master
• MW 1.28: no bug when using the extension branches REL1_28 and master
• MW 1.29alpha: no bug when using the extension branch master

About $wgFileStore

It was indeed removed in MW 1.24. The comment just above in the code clearly says it is kept for B/C and given it is a default value I don’t see any harm in keeping it. If something should be changed, it would not be related to $wgDeleteDirectory, since the goal here is to store viewable files, not deleted files ($wgFileStore was historically only used for deleted files, but the use in this extension is about storing viewable files, unrelated to deleted files).

In nowadays config, possibly it could be checked if a (foreign) repository exists instead of just a wrapper around a file backend (FSRepo, deprecated since MW 1.19), but this would be an architecture change which should be decribed and discussed in a dedicated issue with a broader perspective.

Change 323688 had a related patch set uploaded (by Seb35):
Fix permission denied

https://gerrit.wikimedia.org/r/323688

Change 323688 merged by Hashar:
Fix permission denied

https://gerrit.wikimedia.org/r/323688

I have landed @Seb35 backport of the patch for REL1_26.

@hashar thanks :)

This should now be resolved with @Reedy's change on the master branch.

Fixed by https://gerrit.wikimedia.org/r/#/c/324352/