Page MenuHomePhabricator
Create Task
Maniphest T121737

Add secondary link for the agent to some notification types
Closed, ResolvedPublic
Actions

Assigned To
SBisson
Authored By
• Catrope
Dec 17 2015, 1:11 AM
Tags
Referenced Files
F3515864: Screen Shot 2016-03-03 at 11.30.54 AM.png
Mar 3 2016, 7:52 PM
F3515862: Screen Shot 2016-03-03 at 11.33.52 AM.png
Mar 3 2016, 7:52 PM
F3515512: Screen Shot 2016-03-03 at 9.59.22 AM.png
Mar 3 2016, 6:23 PM
F3328197: Screen Shot 2016-02-09 at 11.51.32 AM.png
Feb 9 2016, 8:16 PM
F3327997: Screen Shot 2016-02-09 at 11.00.47 AM.png
Feb 9 2016, 8:16 PM
F3328135: Screen Shot 2016-02-09 at 9.43.40 AM.png
Feb 9 2016, 8:16 PM
F3328124: Screen Shot 2016-02-05 at 4.40.05 PM.png
Feb 9 2016, 8:16 PM
F3328070: Screen Shot 2016-02-08 at 3.35.37 PM.png
Feb 9 2016, 8:16 PM
View All 19 Files
Subscribers
Aklapper
• Catrope
Etonkovidova
gerritbot
• jmatazzoni
SBisson
StudiesWorld

Description

For the following notification types, we'd like to add a secondary link to the user page (with the label being the user name and the icon being userAvatar) of the agent to serve as a signature of sorts: a consistent way to indicate who performed the action you're being notified about. Where this secondary link is present, it should always be the first secondary link.

Notification types:

flowusertalk-new-topic
flowusertalk-post-reply
flowusertalk-topic-renamed
flowusertalk-post-edited
flowboard-description-edited

Details

SubjectRepoBranchLines +/-
Add agent link to most Flow notificationsmediawiki/extensions/Flowmaster+13 -0
Add agent link to all Thanks notificationsmediawiki/extensions/Thanksmaster+8 -31
Add agent link to all notificationsmediawiki/extensions/OpenStackManagermaster+7 -0
Add agent link to all notificationsmediawiki/extensions/EducationProgrammaster+9 -1
Add agent link to all PageTriage notificationsmediawiki/extensions/PageTriagemaster+21 -0
Add agent link to most notificationsmediawiki/extensions/Echomaster+58 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Catrope created this task.Dec 17 2015, 1:11 AM
• Catrope raised the priority of this task from to Needs Triage.
• Catrope updated the task description. (Show Details)
• Catrope added projects: Notifications, Collaboration-Team-Archive-2015-2016.
• Catrope subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 17 2015, 1:11 AM
• Catrope triaged this task as High priority.Dec 17 2015, 1:11 AM
• Catrope set Security to None.
• Catrope moved this task from Untriaged to Ready for pickup on the Collaboration-Team-Archive-2015-2016 board.
• Catrope updated the task description. (Show Details)
• Catrope mentioned this in T121661: Clean up lego message in user-rights notification.Dec 17 2015, 1:24 AM
• Catrope added a parent task: T121661: Clean up lego message in user-rights notification.
• Catrope mentioned this in T121739: Remove user names from some notification messages in favor of secondary link.Dec 17 2015, 1:45 AM
• Catrope added a parent task: T121739: Remove user names from some notification messages in favor of secondary link.
• Catrope moved this task from Ready for pickup to RFP (notifications) on the Collaboration-Team-Archive-2015-2016 board.Dec 19 2015, 1:22 AM
SBisson claimed this task.Dec 22 2015, 2:47 PM
SBisson moved this task from RFP (notifications) to In Development on the Collaboration-Team-Archive-2015-2016 board.
gerritbot subscribed.Dec 22 2015, 3:59 PM

Change 260587 had a related patch set uploaded (by Sbisson):
Add agent link to most notifications

https://gerrit.wikimedia.org/r/260587

gerritbot added a project: Patch-For-Review.Dec 22 2015, 3:59 PM
SBisson updated the task description. (Show Details)Dec 22 2015, 3:59 PM
gerritbot added a comment.Dec 22 2015, 4:01 PM

Change 260589 had a related patch set uploaded (by Sbisson):
Add agent link to most Flow notifications

https://gerrit.wikimedia.org/r/260589

gerritbot added a comment.Dec 22 2015, 4:03 PM

Change 260590 had a related patch set uploaded (by Sbisson):
Add agent link to all Thanks notifications

https://gerrit.wikimedia.org/r/260590

SBisson updated the task description. (Show Details)Dec 22 2015, 4:04 PM
gerritbot added a comment.Dec 22 2015, 4:19 PM

Change 260594 had a related patch set uploaded (by Sbisson):
Add agent link to all PageTriage notifications

https://gerrit.wikimedia.org/r/260594

SBisson updated the task description. (Show Details)Dec 22 2015, 4:19 PM
gerritbot added a comment.Dec 22 2015, 4:30 PM

Change 260597 had a related patch set uploaded (by Sbisson):
Add agent link to all notifications

https://gerrit.wikimedia.org/r/260597

SBisson updated the task description. (Show Details)Dec 22 2015, 4:37 PM
gerritbot added a comment.Dec 22 2015, 6:49 PM

Change 260623 had a related patch set uploaded (by Sbisson):
Add agent link on al notifications

https://gerrit.wikimedia.org/r/260623

SBisson updated the task description. (Show Details)Dec 22 2015, 6:50 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.
gerritbot added a comment.Jan 11 2016, 10:46 PM

Change 260587 merged by jenkins-bot:
Add agent link to most notifications

https://gerrit.wikimedia.org/r/260587

gerritbot added a comment.Jan 11 2016, 10:46 PM

Change 260594 merged by jenkins-bot:
Add agent link to all PageTriage notifications

https://gerrit.wikimedia.org/r/260594

gerritbot added a comment.Jan 11 2016, 10:46 PM

Change 260597 merged by jenkins-bot:
Add agent link to all notifications

https://gerrit.wikimedia.org/r/260597

gerritbot added a comment.Jan 11 2016, 10:46 PM

Change 260623 merged by jenkins-bot:
Add agent link to all notifications

https://gerrit.wikimedia.org/r/260623

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Jan 11 2016, 10:49 PM
gerritbot added a comment.Jan 11 2016, 10:50 PM

Change 260590 merged by jenkins-bot:
Add agent link to all Thanks notifications

https://gerrit.wikimedia.org/r/260590

gerritbot added a comment.Jan 11 2016, 10:50 PM

Change 260589 merged by jenkins-bot:
Add agent link to most Flow notifications

https://gerrit.wikimedia.org/r/260589

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Jan 11 2016, 11:00 PM
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Jan 26 2016, 11:06 PM
Etonkovidova moved this task from Product Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Jan 26 2016, 11:29 PM
• Catrope added a comment.Feb 9 2016, 8:16 PM

osm-notif.png (88×497 px, 7 KB)

The OpenStackManager ones work on wikitech.

Etonkovidova subscribed.Feb 9 2016, 8:16 PM

Current screenshots:

edit-user-talk

wiki text user talk page

Screen Shot 2016-02-09 at 10.12.51 AM.png (295×573 px, 40 KB)

Flow enabled talk page
Screen Shot 2016-02-09 at 10.17.19 AM.png (287×607 px, 59 KB)

reverted

Screen Shot 2016-02-09 at 11.00.47 AM.png (153×560 px, 27 KB)

mention

Screen Shot 2016-02-09 at 11.05.45 AM.png (223×599 px, 45 KB)

user-rights

Screen Shot 2016-02-08 at 2.20.31 PM.png (266×702 px, 54 KB)

emailuser

Screen Shot 2016-02-09 at 11.11.37 AM.png (157×538 px, 25 KB)

flow-new-topic

Screen Shot 2016-02-09 at 11.11.54 AM.png (178×561 px, 36 KB)

flow-post-reply

Screen Shot 2016-02-09 at 11.17.25 AM.png (180×561 px, 34 KB)

flow-post-edited

Screen Shot 2016-02-09 at 11.19.44 AM.png (179×613 px, 36 KB)

flow-topic-renamed

Screen Shot 2016-02-09 at 11.25.07 AM.png (99×526 px, 21 KB)

flow-mention

Screen Shot 2016-02-08 at 3.35.37 PM.png (374×588 px, 68 KB)

edit-thank

Screen Shot 2016-02-09 at 11.51.32 AM.png (155×562 px, 29 KB)

flow-thank

Screen Shot 2016-02-05 at 4.40.05 PM.png (396×652 px, 92 KB)

All PageTriage notifications

Screen Shot 2016-02-09 at 12.03.06 PM.png (160×541 px, 30 KB)

All EducationProgram notifications

Screen Shot 2016-02-09 at 9.43.40 AM.png (334×617 px, 69 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Feb 9 2016, 8:17 PM
Etonkovidova mentioned this in T121735: Clarify notification icons.Feb 9 2016, 11:36 PM
• jmatazzoni subscribed.Feb 18 2016, 5:42 PM

I checked the spreadsheet and found the following new notification types that also get the agent secondary link:

  • flowusertalk-new-topic
  • flowusertalk-post-reply
  • flowusertalk-topic-renamed
  • flowusertalk-post-edited
  • flowboard-description-edited

I've added those five to the ticket description above. Also, should probably check the OpenStackManager notifications:

  • osm-instance-build-completed
  • osm-instance-reboot-completed
  • osm-instance-deleted
  • osm-projectmembers-add

Moving this back to Q&A.

• jmatazzoni updated the task description. (Show Details)Feb 18 2016, 5:42 PM
• jmatazzoni moved this task from Product Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.
• jmatazzoni added a subscriber: SBisson.
Etonkovidova added a comment.Mar 3 2016, 6:23 PM

The following are checked as part of verifying T121663: Create new notification category for talk pages: flowusertalk
flowusertalk-topic-renamed
flowusertalk-post-edited

Screen Shot 2016-03-03 at 9.59.22 AM.png (296×577 px, 61 KB)

Etonkovidova added a comment.EditedMar 3 2016, 7:52 PM

Checked in betalabs:

flowusertalk-new-topic
flowusertalk-post-reply
flowboard-description-edited

flowusertalk-post-reply and flowboard-description-edited - look/function according to specs - see the screenshot.

@SBisson flowusertalk-new-topic Primary link does not direct to "The Flow board, with sorting order forced to newest topics first]"
Currently, when clicked on flowusertalk-new-topic, the new topic page will be displayed.
Note: When new topics are bundled, the primary link works according to specs.

Screen Shot 2016-03-03 at 11.33.52 AM.png (188×576 px, 35 KB)

Screen Shot 2016-03-03 at 11.30.54 AM.png (368×561 px, 64 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Mar 3 2016, 9:50 PM
SBisson added a comment.Mar 9 2016, 7:56 PM
In T121737#2085707, @Etonkovidova wrote:

@SBisson flowusertalk-new-topic Primary link does not direct to "The Flow board, with sorting order forced to newest topics first]"
Currently, when clicked on flowusertalk-new-topic, the new topic page will be displayed.

I think the primary action for 'flow-new-topic' and 'flowusertalk-new-topic' should be consistent

  • Single: New topic page
  • Bundle: Flow board, sorted by newest topics

Is it possible that this was a mistake in the spec?

• jmatazzoni added a comment.Mar 10 2016, 11:35 PM

Stephane suggests:

I think the primary action for 'flow-new-topic' and 'flowusertalk-new-topic' should be consistent
Single: New topic page
Bundle: Flow board, sorted by newest topics

Makes sense to me. I've updated the spreadsheet and requested comment. Meanwhile, @SBisson, please note that for consistency I've also changed the Primary Link Labels -- to View topic and View topics, respectively.

• jmatazzoni moved this task from Product Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Mar 10 2016, 11:36 PM
Etonkovidova added a comment.Mar 15 2016, 8:00 PM

Checked according to @SBisson comments - all specs are in place.

I think the primary action for 'flow-new-topic' and 'flowusertalk-new-topic' should be consistent
Single: New topic page
Bundle: Flow board, sorted by newest topics

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Mar 15 2016, 8:00 PM
• jmatazzoni closed this task as Resolved.Mar 15 2016, 8:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits