Page MenuHomePhabricator

Unit test failures block merges on ContentTranslation
Closed, ResolvedPublic

Description

Cause of test failure is unknown to me, but used "unbreak now" as this blocks development work (merges). The failure is not transient.

https://integration.wikimedia.org/ci/job/mwext-testextension-zend/17453/consoleFull

07:28:26 There were 2 failures:
07:28:26 
07:28:26 1) Wikibase\Client\Tests\RecentChanges\ChangeLineFormatterTest::testFormat with data set "edit-change" (array(array('a', 'diff'), array('a', 'hist'), array('span', array('mw-changeslist-separator'), '. .'), array('abbr', array('wikibase-edit'), 'D'), array('a', array('plainlinks wb-entity-link', 'http://www.wikidata.org/wiki/Q4'), 'Q4'), array('span', array('mw-changeslist-date'), '11:17'), array('a', array('plainlinks mw-userlink', 'http://www.wikidata.org/wiki/User:Cat'), 'Cat'), array('span', array('mw-usertoollinks')), array('a', array('plainlinks', 'http://www.wikidata.org/wiki/User_talk:Cat'), 'Talk'), array('a', array('plainlinks', 'http://www.wikidata.org/wiki/Special:Contributions/Cat'), 'contribs'), array('span', array('comment'))), array('/title=Q4&amp;curid=5&amp;action=history/', '/title=Q4&amp;curid=5&amp;diff=92&amp;oldid=90/', '/<span class="comment">\\(‎<span dir="auto"><span class="autocomment">Changed claim: <\\/span><\\/span> <a .*?>Property:P213<\\/a>: <a .*?>Q850<\\/a>\\)<\\/span>/'), RecentChange)
07:28:26 edit-usertalk
07:28:26 	(<a class="plainlinks" tabindex="1" href="http://www.wikidata.org/w/index.php?title=Q4&amp;curid=5&amp;diff=92&amp;oldid=90">diff</a> | <a class="plainlinks" href="http://www.wikidata.org/w/index.php?title=Q4&amp;curid=5&amp;action=history">hist</a>) <span class="mw-changeslist-separator">. .</span> <abbr class='wikibase-edit' title='TestWiki edit'>D</abbr> <a href="/index.php?title=Canada&amp;action=edit&amp;redlink=1" class="new" title="Canada (page does not exist)">Canada</a> (<a class="plainlinks wb-entity-link" href="http://www.wikidata.org/wiki/Q4">Q4</a>); <span class="mw-changeslist-date">11:17</span> <span class="mw-changeslist-separator">. .</span> <a class="plainlinks mw-userlink" href="http://www.wikidata.org/wiki/User:Cat">Cat</a> <span class="mw-usertoollinks">(<a class="plainlinks" href="http://www.wikidata.org/wiki/User_talk:Cat">talk</a> | <a class="plainlinks" href="http://www.wikidata.org/wiki/Special:Contributions/Cat">contribs</a>)</span> <span class="comment">(‎<span dir="auto"><span class="autocomment">Changed claim: </span></span> <a class="external" rel="nofollow">Property:P213</a>: <a class="external" rel="nofollow">Q850</a>)</span>
07:28:26 Failed asserting that false is true.
07:28:26 
07:28:26 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:1180
07:28:26 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/client/tests/phpunit/includes/recentchanges/ChangeLineFormatterTest.php:85
07:28:26 /mnt/jenkins-workspace/workspace/mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
07:28:26 
07:28:26 2) Wikibase\Client\Tests\RecentChanges\ChangeLineFormatterTest::testFormat with data set "log-change" (array(array('a', array('plainlinks', 'http://www.wikidata.org/wiki/Special:Log/delete'), 'Deletion log'), array('span', array('mw-changeslist-separator'), '. .'), array('abbr', array('wikibase-edit'), 'D'), array('a', 'Canada'), array('span', array('mw-changeslist-date'), '15:18'), array('a', array('plainlinks mw-userlink', 'http://www.wikidata.org/wiki/User:Cat'), 'Cat'), array('span', array('mw-usertoollinks')), array('a', array('plainlinks', 'http://www.wikidata.org/wiki/User_talk:Cat'), 'Talk'), array('a', array('plainlinks', 'http://www.wikidata.org/wiki/Special:Contributions/Cat'), 'contribs'), array('span', array('comment'))), array('/Log Change Comment/'), RecentChange)
07:28:26 delete-usertalk
07:28:26 	(<a class="plainlinks" href="http://www.wikidata.org/wiki/Special:Log/delete">Deletion log</a>) <span class="mw-changeslist-separator">. .</span> <abbr class='wikibase-edit' title='TestWiki edit'>D</abbr> <a href="/index.php?title=Canada&amp;action=edit&amp;redlink=1" class="new" title="Canada (page does not exist)">Canada</a>; <span class="mw-changeslist-date">15:18</span> <span class="mw-changeslist-separator">. .</span> <a class="plainlinks mw-userlink" href="http://www.wikidata.org/wiki/User:Cat">Cat</a> <span class="mw-usertoollinks">(<a class="plainlinks" href="http://www.wikidata.org/wiki/User_talk:Cat">talk</a> | <a class="plainlinks" href="http://www.wikidata.org/wiki/Special:Contributions/Cat">contribs</a>)</span> <span class="comment">(Log Change Comment)</span>
07:28:26 Failed asserting that false is true.

Event Timeline

Nikerabbit raised the priority of this task from to Unbreak Now!.
Nikerabbit updated the task description. (Show Details)
Nikerabbit moved this task to Backlog on the MediaWiki-extensions-WikibaseClient board.
Nikerabbit added subscribers: Nikerabbit, santhosh, Amire80 and 2 others.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 260721 had a related patch set uploaded (by Legoktm):
Fix up ChangeLineFormatterTest tests for lowercase "talk" message

https://gerrit.wikimedia.org/r/260721

Well spotted. I was trying to figure where does the mysterious Failed asserting that false is true come from.

Change 260721 merged by jenkins-bot:
Fix up ChangeLineFormatterTest tests for lowercase "talk" message

https://gerrit.wikimedia.org/r/260721

Nikerabbit claimed this task.

Fixed quickly, thanks.