We should reduce ResourceLoader modules to max 5-10 for UI. This will improve performance according to @Krinkle
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T59765 Provide JavaScript hook | |||
| Resolved | Lydia_Pintscher | T63131 Eliminate or reduce delay between selection of property and displaying of input fields when adding statements | |||
| Resolved | None | T58090 Do not change targets to javascript:void(0); on JavaScript load for various "edit" links | |||
| Invalid | None | T56098 [Epic][UI] Front-end performance: Improve loading time of items | |||
| Invalid | None | T123233 [Task] Reduce ResourceLoader modules |
Event Timeline
Comment Actions
While the way the resource loader startup module work makes it quite expensive to have a lot of modules (and we also register many of them in client only installations as well), I don't think this is very important, we have quite a few more pressing performance issues.
Comment Actions
Change 263355 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Merge snakview ResourceLoader modules
Comment Actions
Change 263356 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Merge PageConnector into linkitem ResourceLoder module
Comment Actions
Change 263356 abandoned by Thiemo Mättig (WMDE):
Merge PageConnector into linkitem ResourceLoder module
Comment Actions
Change 263357 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Merge ResourceLoader submodules into wikibase.parsers.getStore
Comment Actions
Change 263358 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Merge EntityInitializer into wikibase.ui.entityViewInit Module
Comment Actions
Change 263358 merged by jenkins-bot:
Merge EntityInitializer into wikibase.ui.entityViewInit Module
Comment Actions
Change 263357 merged by jenkins-bot:
Merge ResourceLoader submodules into wikibase.parsers.getStore
Comment Actions
Change 263591 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Merge ResourceLoader submodules into wikibase.formatters.getStore
Comment Actions
Again, please don't do such architectural changes which are not in the sprint, not discussed and happen to be reverts of work we did before. Especially since I explicitly stated today that I'm against this.
Comment Actions
What I did to this point was pure refactoring that did not changed anything critical. Not different from other refactoring we do, e.g. when we remove unused public methods. I merged some very trivial modules (mostly 1 or 2 files only) that are not used outside of the same directory. Such minor changes do not need to be in a sprint.
I do not plan to do more than I already did to this point.
Comment Actions
It's still a partial revert of dcaff383b9b83971646d26a6ec50b3829c9f88d9. I don't like going back and forth for no good reason and without good reasoning.
Comment Actions
Change 263591 abandoned by Thiemo Mättig (WMDE):
Merge ResourceLoader submodules into wikibase.formatters.getStore
Reason:
Mostly obsolete because of I60935f8.