Page MenuHomePhabricator
Create Task
Maniphest T125001

Move HtmlFormatter into a separate Composer package
Closed, ResolvedPublic
Actions

Description

Some time ago, it ended up in core because we wanted to integrate some mobile support and because we wanted to share this library across several extensions, having no Composer support. It makes no sense to keep it where it currently is.

3 extensions currently depending on it would require an update:

  • CirrusSearch
  • MobileFrontend
  • TextExtracts

Details

SubjectRepoBranchLines +/-
Switch to librarized HtmlFormattermediawiki/extensions/LinkTargetmaster+1 -3
Switch to librarized HtmlFormattermediawiki/extensions/MobileFrontendmaster+2 -0
Switch to librarized HtmlFormattermediawiki/extensions/CirrusSearchmaster+1 -1
Switch to librarized HtmlFormattermediawiki/extensions/TextExtractsmaster+2 -1
Switch to external HtmlFormattermediawiki/coremaster+7 -486
Add HtmlFormattermediawiki/vendormaster+847 -2
doc: Add HtmlFormatterintegration/docrootmaster+1 -0
Initial commitHtmlFormattermaster+963 -0
Add HtmlFormatterintegration/configmaster+7 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

MaxSem created this task.Jan 27 2016, 11:17 PM
MaxSem raised the priority of this task from to Needs Triage.
MaxSem updated the task description. (Show Details)
MaxSem added projects: MediaWiki-General, Librarization, MobileFrontend, CirrusSearch, TextExtracts, Technical-Debt.
MaxSem subscribed.
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptJan 27 2016, 11:17 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
bd808 triaged this task as Low priority.Jan 28 2016, 6:12 PM
bd808 subscribed.
Danny_B moved this task from Unsorted to Move on the Technical-Debt board.Jan 30 2016, 12:29 AM
Legoktm subscribed.Jan 30 2016, 9:12 AM

First step to make library-ifying easier is to move the HtmlFormatter class into libs, and audit it for any dependencies it might have on MW. After that, we just have to set up the library framework/boostrap, and boring stuff :)

gerritbot subscribed.Jan 30 2016, 9:22 AM

Change 267391 had a related patch set uploaded (by MaxSem):
Initial commit

https://gerrit.wikimedia.org/r/267391

gerritbot added a project: Patch-For-Review.Jan 30 2016, 9:22 AM
MaxSem added a comment.Jan 30 2016, 9:22 AM

Forgot to link to this bug from the commit :)

gerritbot added a comment.Feb 9 2016, 9:24 PM

Change 269530 had a related patch set uploaded (by MaxSem):
Add HtmlFormatter

https://gerrit.wikimedia.org/r/269530

gerritbot added a comment.Feb 10 2016, 12:53 PM

Change 269530 merged by jenkins-bot:
Add HtmlFormatter

https://gerrit.wikimedia.org/r/269530

MaxSem added a comment.Feb 11 2016, 11:35 PM

Now need to publish it on Packagist...

bd808 added a comment.Feb 11 2016, 11:39 PM
In T125001#2021106, @MaxSem wrote:

Now need to publish it on Packagist...

I can set that up for you as soon as the repo is replicated to GitHub. (404 for me at https://github.com/wikimedia/HtmlFormatter)

bd808 added a comment.Feb 11 2016, 11:54 PM
In T125001#2021115, @bd808 wrote:
In T125001#2021106, @MaxSem wrote:

Now need to publish it on Packagist...

I can set that up for you as soon as the repo is replicated to GitHub. (404 for me at https://github.com/wikimedia/HtmlFormatter)

< bd808> ostriches: MaxSem's new repo doesn't seem to be replicated to GitHub -- https://gerrit.wikimedia.org/r/#/admin/projects/HtmlFormatter
<ostriches> bd808: creations aren't automatic anymore
<ostriches> Create and it'll replicate:)

bd808 created repository wikimedia/HtmlFormatter
2016-02-11 at 16:50

gerritbot added a comment.Feb 12 2016, 9:07 AM

Change 267391 merged by jenkins-bot:
Initial commit

https://gerrit.wikimedia.org/r/267391

Legoktm added a comment.Feb 12 2016, 9:10 AM

The repository is now replicated to github and I fixed the gerrit permissions on the repository so jenkins bot can merge there. :D

I think the only thing left before tagging a version is to fill out the "TODO Write stuff here" currently in the README ;-)

gerritbot added a comment.Feb 12 2016, 9:12 AM

Change 270251 had a related patch set uploaded (by Legoktm):
doc: Add HtmlFormatter

https://gerrit.wikimedia.org/r/270251

gerritbot added a comment.Feb 12 2016, 9:14 AM

Change 270251 merged by jenkins-bot:
doc: Add HtmlFormatter

https://gerrit.wikimedia.org/r/270251

Legoktm added a comment.Feb 12 2016, 9:16 AM

I just realized that the API help in MediaWiki core depends upon this, so the library will need to become a mw core dependency as well.

bd808 added a comment.Feb 12 2016, 4:48 PM
In T125001#2021106, @MaxSem wrote:

Now need to publish it on Packagist...

Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Feb 18 2016, 6:40 PM
Jdlrobson moved this task from Team:Growth to team:other on the MobileFrontend board.Feb 18 2016, 6:43 PM
phuedx subscribed.Mar 29 2016, 9:59 AM

@MaxSem, @bd808: Is this done?

MaxSem added a subtask: T129435: RFC: drop support for running without mbstring.Mar 29 2016, 3:22 PM

I'm waiting on T129435 because I want that ugly fallback HtmlFormatter employs to die.

Ricordisamoa subscribed.Mar 31 2016, 8:33 PM
MaxSem closed subtask T129435: RFC: drop support for running without mbstring as Resolved.Apr 6 2016, 10:56 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptApr 6 2016, 10:56 PM
gerritbot added a comment.Apr 11 2016, 11:39 PM

Change 282831 had a related patch set uploaded (by MaxSem):
Add HtmlFormatter

https://gerrit.wikimedia.org/r/282831

Legoktm added a project: MediaWiki-Vendor.Apr 12 2016, 6:42 PM
Legoktm set Security to None.
gerritbot added a comment.Apr 12 2016, 7:47 PM

Change 282831 merged by jenkins-bot:
Add HtmlFormatter

https://gerrit.wikimedia.org/r/282831

gerritbot added a comment.Apr 12 2016, 8:22 PM

Change 283009 had a related patch set uploaded (by MaxSem):
Switch to external HtmlFormatter

https://gerrit.wikimedia.org/r/283009

gerritbot added a comment.Apr 13 2016, 2:47 AM

Change 283009 merged by jenkins-bot:
Switch to external HtmlFormatter

https://gerrit.wikimedia.org/r/283009

gerritbot added a comment.Apr 13 2016, 4:24 AM

Change 283122 had a related patch set uploaded (by MaxSem):
Switch to librarized HtmlFormatter

https://gerrit.wikimedia.org/r/283122

gerritbot added a comment.Apr 13 2016, 4:27 AM

Change 283123 had a related patch set uploaded (by MaxSem):
Switch to librarized HtmlFormatter

https://gerrit.wikimedia.org/r/283123

gerritbot added a comment.Apr 13 2016, 4:28 AM

Change 283124 had a related patch set uploaded (by MaxSem):
Switch to librarized HtmlFormatter

https://gerrit.wikimedia.org/r/283124

gerritbot added a comment.Apr 13 2016, 7:24 AM

Change 283122 merged by jenkins-bot:
Switch to librarized HtmlFormatter

https://gerrit.wikimedia.org/r/283122

gerritbot added a comment.Apr 13 2016, 7:31 AM

Change 283124 merged by jenkins-bot:
Switch to librarized HtmlFormatter

https://gerrit.wikimedia.org/r/283124

gerritbot added a comment.Apr 13 2016, 7:51 AM

Change 283123 merged by jenkins-bot:
Switch to librarized HtmlFormatter

https://gerrit.wikimedia.org/r/283123

gerritbot added a comment.Apr 13 2016, 5:54 PM

Change 283237 had a related patch set uploaded (by MaxSem):
Switch to librarized HtmlFormatter

https://gerrit.wikimedia.org/r/283237

MaxSem closed this task as Resolved.Apr 13 2016, 5:55 PM
MaxSem claimed this task.

All WMF-deployed stuff is done, one non-WMF extension is pending review.

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), MW-1.27-release-notes.Apr 19 2016, 9:02 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 9:02 PM
gerritbot added a comment.Apr 20 2016, 5:37 PM

Change 283237 merged by MaxSem:
Switch to librarized HtmlFormatter

https://gerrit.wikimedia.org/r/283237

MaxSem mentioned this in rELTGf8bb161ed1d9: Switch to librarized HtmlFormatter.May 25 2023, 7:05 PM
Maintenance_bot removed a project: Patch-For-Review.May 25 2023, 7:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits