Page MenuHomePhabricator
Create Task
Maniphest T126594

Disable HHVM fcgi server on CI slaves
Closed, ResolvedPublic
Actions

Description

The Trusty slaves have hhvm running in the background but we have no use for it:

19287 ?        Ssl    0:02 /usr/bin/hhvm --config /etc/hhvm/fcgi.ini --mode server
19297 ?        Ss     0:00  \_ /usr/bin/hhvm --config /etc/hhvm/fcgi.ini --mode server
19298 ?        Ss     0:00  \_ /usr/bin/hhvm --config /etc/hhvm/fcgi.ini --mode server
19299 ?        Ss     0:00  \_ /usr/bin/hhvm --config /etc/hhvm/fcgi.ini --mode server
19300 ?        Ss     0:00  \_ /usr/bin/hhvm --config /etc/hhvm/fcgi.ini --mode server
19301 ?        Ss     0:00  \_ /usr/bin/hhvm --config /etc/hhvm/fcgi.ini --mode server

The qunit jobs are hitting Apache and Zend PHP.

Rest of hhvm jobs are just invoking hhvm from the command line.

Details

SubjectRepoBranchLines +/-
contint: disable HHVM background serviceoperations/puppetproduction+8 -0
hhvm: allow passing service parametersoperations/puppetproduction+19 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Feb 11 2016, 11:00 AM
hashar raised the priority of this task from to High.
hashar updated the task description. (Show Details)
hashar added a project: Continuous-Integration-Infrastructure.
hashar added subscribers: gerritbot, Krinkle, greg and 4 others.
gerritbot added a comment.Feb 11 2016, 11:21 AM

Change 269946 had a related patch set uploaded (by Hashar):
hhvm: can now change enable/ensure service

https://gerrit.wikimedia.org/r/269946

gerritbot added a project: Patch-For-Review.Feb 11 2016, 11:21 AM

Change 269947 had a related patch set uploaded (by Hashar):
contint: disable HHVM background service

https://gerrit.wikimedia.org/r/269947

hashar claimed this task.Feb 11 2016, 11:40 AM
hashar moved this task from Untriaged to Done on the Continuous-Integration-Infrastructure board.

I have cherry picked both patches on the integration puppetmaster. That got rid of the hhvm service.

Now pending ops review / merging of the couple scary patches.

hashar mentioned this in T126658: /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/luasandbox.so no such file or directory.Feb 11 2016, 8:52 PM
hashar added a subtask: T126658: /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/luasandbox.so no such file or directory.Feb 11 2016, 9:02 PM
hashar changed the task status from Open to Stalled.Feb 11 2016, 9:17 PM
hashar moved this task from Done to Externally Blocked on the Continuous-Integration-Infrastructure board.

stalled / pending symlink fix :D

hashar added a comment.Feb 11 2016, 9:17 PM

I have removed the cherry pick from the CI puppetmaster. So hhvm service is back around

Krinkle unsubscribed.Feb 23 2016, 4:47 PM
hashar lowered the priority of this task from High to Low.Apr 19 2016, 9:37 AM
hashar closed subtask T126658: /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/luasandbox.so no such file or directory as Resolved.Apr 20 2016, 1:30 PM
hashar changed the task status from Stalled to Open.Apr 20 2016, 1:57 PM

HHVM configuration files pointed to /usr/lib/x86_64-linux-gnu/hhvm/extensions/current which was created by the HHVM Upstart service. Hence we required the HHVM service to start. With T126658 that got solved by referencing the HHVM API version instead and the upstart service is no more needed.

Thus I have rebased the couple patches I had in puppet that would let us disable the HHVM service:

https://gerrit.wikimedia.org/r/#/c/269946/
https://gerrit.wikimedia.org/r/#/c/269947/

Both cherry picked on CI puppet master.

Stashbot subscribed.Apr 20 2016, 1:58 PM

Mentioned in SAL [2016-04-20T13:58:43Z] <hashar> Stopping HHVM on CI slaves by cherry picking a couple puppet patches | T126594

hashar added a project: Blocked-on-Operations.Apr 25 2016, 8:20 PM

Pending review and merge of puppet patches by SRE

https://gerrit.wikimedia.org/r/#/c/269946/
https://gerrit.wikimedia.org/r/#/c/269947/

hashar added a parent task: T119139: [keyresult] Migrate php (Zend and HHVM) CI jobs to Nodepool.Apr 25 2016, 8:22 PM
hashar removed hashar as the assignee of this task.Apr 25 2016, 8:33 PM
gerritbot added a comment.May 5 2016, 7:37 AM

Change 269946 merged by Alexandros Kosiaris:
hhvm: allow passing service parameters

https://gerrit.wikimedia.org/r/269946

gerritbot added a comment.May 5 2016, 7:38 AM

Change 269947 merged by Alexandros Kosiaris:
contint: disable HHVM background service

https://gerrit.wikimedia.org/r/269947

hashar closed this task as Resolved.May 9 2016, 10:03 AM
hashar claimed this task.
hashar added a subscriber: akosiaris.

Thank you @akosiaris . I have confirmed HHVM is gone from permanent CI slaves and from the Nodepool instances (both Trusty and Jessie).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL