Page MenuHomePhabricator
Create Task
Maniphest T126672

CirrusSearch fatal
Closed, ResolvedPublic
Actions

Description

I get an error when I visit http://en.m.wikipedia.beta.wmflabs.org/w/index.php?search=Test%20is%20used%20by%20Selenium%20web%20driver

Error is:

Exception encountered, of type "BadMethodCallException"
[d3566207] /w/index.php?search=Test%20is%20used%20by%20Selenium%20web%20driver BadMethodCallException from line 85 of /srv/mediawiki/php-master/extensions/CirrusSearch/includes/InterwikiSearcher.php: Call to a member function get() on a non-object (NULL)
Backtrace:
#0 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/CirrusSearch.php(373): CirrusSearch\InterwikiSearcher->getInterwikiResults(string)
#1 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/CirrusSearch.php(126): CirrusSearch->searchTextReal(string, NULL)
#2 /srv/mediawiki/php-master/includes/specials/SpecialSearch.php(273): CirrusSearch->searchText(string)
#3 /srv/mediawiki/php-master/includes/specials/SpecialSearch.php(217): SpecialSearch->showResults(string)
#4 /srv/mediawiki/php-master/includes/specials/SpecialSearch.php(133): SpecialSearch->goResult(string)
#5 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(407): SpecialSearch->execute(NULL)
#6 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(565): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(282): SpecialPageFactory::executePath(Title, RequestContext)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(738): MediaWiki->performRequest()
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(519): MediaWiki->main()
#10 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): include(string)
#12 {main}

Details

SubjectRepoBranchLines +/-
Allow access to $config from extending classesmediawiki/extensions/CirrusSearchwmf/1.27.0-wmf.14+1 -1
Allow access to $config from extending classesmediawiki/extensions/CirrusSearchmaster+1 -1
Provide access to SearchConfig in InterwikiSearchermediawiki/extensions/CirrusSearchmaster+8 -1
Replace usage of wgMemc with ObjectCache::getLocalClusterInstance()mediawiki/extensions/CirrusSearchmaster+16 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Feb 11 2016, 9:59 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: CirrusSearch.
Jdlrobson subscribed.
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptFeb 11 2016, 9:59 PM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Jdlrobson added a parent task: T94156: Fix MobileFrontend scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily.Feb 11 2016, 10:00 PM
gerritbot subscribed.Feb 11 2016, 10:07 PM

Change 270117 had a related patch set uploaded (by EBernhardson):
Replace usage of wgMemc with ObjectCache::getLocalClusterInstance()

https://gerrit.wikimedia.org/r/270117

gerritbot added a project: Patch-For-Review.Feb 11 2016, 10:07 PM
Jdlrobson added a comment.Feb 11 2016, 10:10 PM

Do we know what broke this?

EBernhardson subscribed.Feb 11 2016, 10:16 PM

not really sure, wgMemc still looks to exist in core (at least, i don't see a recent commit that removes it).

It's good hygiene to stop using $wgMemc anyways, its not even guaranteed to be memcache.

EBernhardson claimed this task.Feb 11 2016, 11:11 PM
EBernhardson added a project: Discovery-Search (Current work).
EBernhardson set Security to None.
EBernhardson moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.
• Deskana triaged this task as Medium priority.Feb 11 2016, 11:11 PM
• Deskana subscribed.
• ksmith moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.Feb 11 2016, 11:12 PM
EBernhardson merged a task: T126695: [betalabs] "BadMethodCallException" for searching a page that does not exist.Feb 12 2016, 12:30 AM
EBernhardson added a subscriber: Etonkovidova.
gerritbot added a comment.Feb 12 2016, 1:18 AM

Change 270117 merged by jenkins-bot:
Replace usage of wgMemc with ObjectCache::getLocalClusterInstance()

https://gerrit.wikimedia.org/r/270117

• Deskana moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Feb 13 2016, 1:16 AM
phuedx subscribed.Feb 15 2016, 7:36 AM

Despite 270117 being deployed to the Beta Cluster, I still see the exception if I navigate to https://en.m.wikipedia.beta.wmflabs.org/w/index.php?search=Test+is+used+by+Selenium+web+driver.

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 16 2016, 6:02 PM
gerritbot added a comment.Feb 16 2016, 7:04 PM

Change 271027 had a related patch set uploaded (by EBernhardson):
Provide access to SearchConfig in InterwikiSearcher

https://gerrit.wikimedia.org/r/271027

gerritbot added a comment.Feb 16 2016, 8:02 PM

Change 271027 abandoned by EBernhardson:
Provide access to SearchConfig in InterwikiSearcher

Reason:
wrong solution

https://gerrit.wikimedia.org/r/271027

gerritbot added a comment.Feb 16 2016, 8:05 PM

Change 271049 had a related patch set uploaded (by EBernhardson):
Allow access to $config from extending classes

https://gerrit.wikimedia.org/r/271049

gerritbot added a comment.Feb 16 2016, 8:36 PM

Change 271049 merged by jenkins-bot:
Allow access to $config from extending classes

https://gerrit.wikimedia.org/r/271049

gerritbot added a comment.Feb 16 2016, 9:17 PM

Change 271071 had a related patch set uploaded (by EBernhardson):
Allow access to $config from extending classes

https://gerrit.wikimedia.org/r/271071

gerritbot added a comment.Feb 16 2016, 9:26 PM

Change 271071 merged by jenkins-bot:
Allow access to $config from extending classes

https://gerrit.wikimedia.org/r/271071

Jdlrobson closed this task as Resolved.Feb 16 2016, 9:50 PM

Thanks guys!

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-16_(1.27.0-wmf.14)).Feb 17 2016, 11:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits