Page MenuHomePhabricator
Create Task
Maniphest T94156

Fix MobileFrontend scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily
Closed, ResolvedPublic
Actions

Assigned To
Jdlrobson
Authored By
zeljkofilipin
Mar 27 2015, 11:49 AM
Tags
Referenced Files
None
Subscribers
Aklapper
dduvall
gerritbot
hashar
Jdlrobson
phuedx
zeljkofilipin

Description

All MobileFrontend browsertests Jenkins jobs are failing:

https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/

Do you need help fixing the failing jobs? If nobody cares, I will delete failing jobs in a week.

Details

SubjectRepoBranchLines +/-
Disable scenarios that fail at en.wikipedia.beta.wmflabs.org from running dailymediawiki/extensions/MobileFrontendmaster+7 -4
Specify Special:EditWatchlist in watchlist switching testsmediawiki/extensions/MobileFrontendmaster+1 -1
Make SchemaEdit#log always return jQuery.Promisemediawiki/extensions/MobileFrontendwmf/1.27.0-wmf.13+2 -0
Make SchemaEdit#log always return jQuery.Promisemediawiki/extensions/MobileFrontendwmf/1.27.0-wmf.12+2 -0
Make SchemaEdit#log always return jQuery.Promisemediawiki/extensions/MobileFrontendmaster+2 -0
QA: Remove failing VisualEditor test due to toolbar changesmediawiki/extensions/MobileFrontendmaster+0 -17
QA: Fix the browser tests to reflect anonymous editing on beta labsmediawiki/extensions/MobileFrontendmaster+6 -1
Don't expose the toggling init functionmediawiki/extensions/MobileFrontendmaster+1 -1
QA: Main menu is now a navmediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
zeljkofilipin added a comment.Mar 30 2015, 2:07 PM

Ok, no jobs will be deleted. :) Feel fee to reach out to Release-Engineering-Team team if you need help. Also, I have proposed Workshop: Fix broken browsertests/Selenium Jenkins jobs (T94299) for this year's hackathons.

zeljkofilipin moved this task from Ruby to Inbox on the Browser-Tests-Infrastructure board.Mar 30 2015, 2:15 PM
zeljkofilipin moved this task from Inbox to Next on the Browser-Tests-Infrastructure board.Apr 3 2015, 1:54 PM
Krinkle removed a project: Continuous-Integration-Infrastructure.Apr 7 2015, 2:26 PM
• KLans_WMF moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Apr 7 2015, 7:22 PM
• KLans_WMF added a project: Mobile-Web-Sprint-45-Snakes-On-A-Plane.Apr 14 2015, 8:22 PM
• KLans_WMF moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.
Jdlrobson added a comment.Apr 20 2015, 9:55 PM

Tests fail for the following reasons

  • Problem with the main menu rules When I click on "Nearby" in the main navigation menu' and Then I should see a link to the disclaimer'
  • Table of contents heading incorrectly has section-heading class
  • Edit button/drawer behaviour has changed due to anonymous editing change.
  • VisualEditor removed the bold button "Then I should see a bold button" is no longer relevant.
  • Some issues with search and there browser tests which will be easy to fix in conjunction with - https://phabricator.wikimedia.org/T96619
gerritbot subscribed.Apr 20 2015, 10:01 PM

Change 205447 had a related patch set uploaded (by Jdlrobson):
QA: Main menu is now a nav

https://gerrit.wikimedia.org/r/205447

gerritbot added a project: Patch-For-Review.Apr 20 2015, 10:01 PM

Change 205448 had a related patch set uploaded (by Jdlrobson):
QA: Fix failing VisualEditor test due to toolbar changes

https://gerrit.wikimedia.org/r/205448

Jdlrobson claimed this task.Apr 20 2015, 10:03 PM
gerritbot added a comment.Apr 20 2015, 10:08 PM

Change 205450 had a related patch set uploaded (by Jdlrobson):
Don't expose the toggling init function

https://gerrit.wikimedia.org/r/205450

Jdlrobson moved this task from To Do to Code Review on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 20 2015, 10:09 PM
gerritbot added a comment.Apr 20 2015, 10:17 PM

Change 205451 had a related patch set uploaded (by Jdlrobson):
QA: Fix the browser tests to reflect anonymous editing on beta labs

https://gerrit.wikimedia.org/r/205451

gerritbot added a comment.Apr 21 2015, 9:35 AM

Change 205447 merged by jenkins-bot:
QA: Main menu is now a nav

https://gerrit.wikimedia.org/r/205447

Jdlrobson mentioned this in rMEXT77688e19a0b5: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 21 2015, 9:35 AM
Jdlrobson mentioned this in rEMFR7426e616cb6a: QA: Main menu is now a nav.
phuedx added a project: Gather Sprint Forward.Apr 21 2015, 9:47 AM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 21 2015, 11:14 AM
Jdlrobson moved this task from In Analysis to Code review needed on the Gather Sprint Forward board.Apr 21 2015, 5:54 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.
gerritbot added a comment.Apr 21 2015, 5:59 PM

Change 205450 merged by jenkins-bot:
Don't expose the toggling init function

https://gerrit.wikimedia.org/r/205450

Jdlrobson mentioned this in rEMFR27f7f183a9fa: Don't expose the toggling init function.Apr 21 2015, 5:59 PM
Jdlrobson mentioned this in rMEXT81820d5603d1: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
gerritbot added a comment.Apr 21 2015, 6:10 PM

Change 205451 merged by jenkins-bot:
QA: Fix the browser tests to reflect anonymous editing on beta labs

https://gerrit.wikimedia.org/r/205451

Jdlrobson mentioned this in rEMFR59ba4a933465: QA: Fix the browser tests to reflect anonymous editing on beta labs.Apr 21 2015, 6:10 PM
Diffusion mentioned this in rMEXTd879faa642f0: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 21 2015, 6:10 PM
gerritbot added a comment.Apr 22 2015, 8:53 AM

Change 205448 merged by jenkins-bot:
QA: Remove failing VisualEditor test due to toolbar changes

https://gerrit.wikimedia.org/r/205448

Diffusion mentioned this in rMEXTb03bf39cf5c5: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 22 2015, 8:53 AM
phuedx moved this task from Code Review to Done on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 22 2015, 8:53 AM
Jdlrobson mentioned this in rEMFRaba23af77a10: QA: Remove failing VisualEditor test due to toolbar changes.Apr 22 2015, 8:54 AM
phuedx closed this task as Resolved.Apr 22 2015, 8:54 AM
phuedx subscribed.

All yer patches are merged @Jdlrobson.

hashar added a comment.EditedApr 22 2015, 9:11 AM

Logged in with my LDAP account, I have manually triggered runs for the three browser tests jobs at https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/

Once completed, should get us results on:

That last job passed overnight so I guess it is a good indication the patches fixed something :-)

hashar reopened this task as Open.Apr 22 2015, 12:54 PM

Reopening since the builds I triggered earlier have some failures. The trend shows a large improvement though!

phuedx moved this task from Done to -1 (Needs More Work) on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 22 2015, 3:26 PM
• Jhernandez moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Forward board.Apr 23 2015, 11:18 AM
Jdlrobson added a subtask: T96920: beta cluster scap failure.Apr 23 2015, 7:02 PM

@hashar remaining 2 test failures are due to T96920 and the required frontend changes not propagating up to the server yet.

https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/623/#showFailuresLink

Jdlrobson moved this task from Needs more development (-1) to Ready for signoff on the Gather Sprint Forward board.Apr 23 2015, 7:04 PM
hashar closed subtask T96920: beta cluster scap failure as Resolved.Apr 24 2015, 7:56 PM
Jdlrobson closed this task as Resolved.Apr 27 2015, 8:26 PM

\o/
https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/627/

• KLans_WMF moved this task from -1 (Needs More Work) to Done on the Mobile-Web-Sprint-45-Snakes-On-A-Plane board.Apr 27 2015, 11:58 PM
zeljkofilipin added a comment.Apr 28 2015, 7:45 AM

Wait, not all MobileFrontend Jenkins jobs are fixed:

https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/

Jdlrobson added a comment.Apr 28 2015, 7:13 PM

#627 passed. We'll open more specific bugs from now on e.g. T97460

Jdlrobson moved this task from Ready for signoff to Done on the Gather Sprint Forward board.Apr 28 2015, 11:00 PM
zeljkofilipin moved this task from Next to Done on the Browser-Tests-Infrastructure board.Apr 29 2015, 5:23 PM
zeljkofilipin reopened this task as Open.Feb 10 2016, 3:43 PM

All MobileFrontend jobs are broken again. :/

https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/

Feel free to create subtasks.

zeljkofilipin mentioned this in T94150: Fix scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily.Feb 10 2016, 3:44 PM
phuedx removed Jdlrobson as the assignee of this task.Feb 10 2016, 6:19 PM
phuedx claimed this task.Feb 10 2016, 6:44 PM
gerritbot added a comment.Feb 10 2016, 7:04 PM

Change 269751 had a related patch set uploaded (by Phuedx):
Make SchemaEdit#log always return jQuery.Promise

https://gerrit.wikimedia.org/r/269751

Jdlrobson added a subtask: T126466: Fix failing browser test due to user profile removal.Feb 10 2016, 7:19 PM
Jdlrobson added a subtask: T126497: Mobile wikitext editing broken when user isn't in Schema:Edit bucket.Feb 10 2016, 7:21 PM
gerritbot added a comment.Feb 10 2016, 7:32 PM

Change 269755 had a related patch set uploaded (by Alex Monk):
Make SchemaEdit#log always return jQuery.Promise

https://gerrit.wikimedia.org/r/269755

gerritbot added a comment.Feb 10 2016, 8:29 PM

Change 269751 merged by jenkins-bot:
Make SchemaEdit#log always return jQuery.Promise

https://gerrit.wikimedia.org/r/269751

gerritbot added a comment.Feb 10 2016, 10:15 PM

Change 269848 had a related patch set uploaded (by Jforrester):
Make SchemaEdit#log always return jQuery.Promise

https://gerrit.wikimedia.org/r/269848

gerritbot added a comment.Feb 10 2016, 10:31 PM

Change 269848 merged by Alex Monk:
Make SchemaEdit#log always return jQuery.Promise

https://gerrit.wikimedia.org/r/269848

gerritbot added a comment.Feb 10 2016, 10:37 PM

Change 269755 merged by Alex Monk:
Make SchemaEdit#log always return jQuery.Promise

https://gerrit.wikimedia.org/r/269755

Jdforrester-WMF closed subtask T126497: Mobile wikitext editing broken when user isn't in Schema:Edit bucket as Resolved.Feb 10 2016, 10:47 PM
Jdlrobson closed subtask T126466: Fix failing browser test due to user profile removal as Resolved.Feb 11 2016, 10:00 PM
Jdlrobson added a subtask: T126672: CirrusSearch fatal.
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release (WMF-deploy-2016-02-09_(1.27.0-wmf.13)), MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).Feb 16 2016, 4:02 PM
Jdlrobson closed subtask T126672: CirrusSearch fatal as Resolved.Feb 16 2016, 9:50 PM
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson added a comment.Feb 16 2016, 10:29 PM

The remaining tests are failing with "Net::ReadTimeout (Net::ReadTimeout)"
The watchlist feature is fine so these seem to be false positives. @zeljkofilipin your team is likely to be better equipped to get to the bottom of these problems.
https://integration.wikimedia.org/ci/view/BrowserTests/view/MobileFrontend/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/955/

zeljkofilipin renamed this task from Fix failed MobileFrontend browsertests Jenkins jobs to Disable MobileFrontend scenarios that fail at en.wikipedia.beta.wmflabs.org from running daily.Feb 22 2016, 3:39 PM
zeljkofilipin claimed this task.
zeljkofilipin added a subscriber: dduvall.Feb 22 2016, 3:53 PM

@Jdlrobson: the only way we can make test maintenance sustainable is to teach you how to fix them. If anybody from your team wants to pair on fixing the tests, my calendar is always up to date. I do not want to volunteer @dduvall, but he also knows how to fix tests. You will have to check with him if he is available.

zeljkofilipin renamed this task from Disable MobileFrontend scenarios that fail at en.wikipedia.beta.wmflabs.org from running daily to Fix MobileFrontend scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily.Feb 25 2016, 3:15 PM
gerritbot added a comment.Mar 2 2016, 10:52 AM

Change 274357 had a related patch set uploaded (by Zfilipin):
Disable scenarios that fail at en.wikipedia.beta.wmflabs.org from running daily

https://gerrit.wikimedia.org/r/274357

gerritbot added a project: Patch-For-Review.Mar 2 2016, 10:52 AM
zeljkofilipin moved this task from Done to Code Review on the Browser-Tests-Infrastructure board.Mar 2 2016, 1:05 PM
zeljkofilipin added a subtask: T129328: Net::ReadTimeout in MobileFrontend browser tests when visiting Watchlist page.Mar 9 2016, 10:26 AM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Mar 10 2016, 2:10 PM
gerritbot added a comment.Mar 16 2016, 6:09 PM

Change 277821 had a related patch set uploaded (by Jdlrobson):
Specify Special:EditWatchlist in watchlist switching tests

https://gerrit.wikimedia.org/r/277821

Jdlrobson added a comment.Mar 16 2016, 6:13 PM

The thing that is strange is Sauce Labs seems to be navigating to Special:Watchlist via the hamburger menu. Is there a rule in one of the libraries that could be being used instead of the one in MobileFrontend?

I am on the "Special:Watchlist" page
seems to be invoking the
I click on "Watchlist" in the main navigation menu
step but it shouldn't be.

gerritbot added a comment.Mar 18 2016, 9:16 PM

Change 277821 merged by jenkins-bot:
Specify Special:EditWatchlist in watchlist switching tests

https://gerrit.wikimedia.org/r/277821

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Mar 18 2016, 10:00 PM
Jdlrobson created subtask T130423: Watchstar broken on beta cluster.Mar 18 2016, 10:05 PM
• bmansurov closed subtask T130423: Watchstar broken on beta cluster as Resolved.Mar 22 2016, 10:31 PM
Jdlrobson added a subtask: T130971: `Generic special page features.Search from Watchlist` test failing with Net::ReadTimeout.Mar 25 2016, 11:30 PM
gerritbot added a comment.Mar 30 2016, 10:14 PM

Change 274357 merged by jenkins-bot:
Disable scenarios that fail at en.wikipedia.beta.wmflabs.org from running daily

https://gerrit.wikimedia.org/r/274357

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)).Mar 31 2016, 9:02 AM
Jdlrobson closed this task as Resolved.Apr 1 2016, 7:35 AM
Jdlrobson claimed this task.

They are more or less passing now except a few occasions of flakey failures in the Firefox build.

Jdlrobson closed subtask T129328: Net::ReadTimeout in MobileFrontend browser tests when visiting Watchlist page as Resolved.May 5 2016, 4:26 PM
• jhobs closed subtask T130971: `Generic special page features.Search from Watchlist` test failing with Net::ReadTimeout as Invalid.Sep 29 2016, 8:33 PM
• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2015-16 Q4 on the Web-Team-Backlog board.Mar 6 2018, 11:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits