Extra lines being inserted in edited transclusion wikitext serialisation when “block” format due to unexpected extra spaces
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	Ltrlg
	Feb 28 2016, 12:25 PM

Description

I’ve seen two problematic editions on articles where the infobox’s templatedata contains format: block:

The diff is unreadable… I guess this is caused by the space on each line before the delimiting pipe?

Related Objects

Mentioned In: T111674: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions

Event Timeline

Ltrlg created this task.Feb 28 2016, 12:25 PM

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 28 2016, 12:25 PM

matmarex subscribed.Feb 29 2016, 8:34 PM

matmarex triaged this task as High priority.Feb 29 2016, 8:39 PM

matmarex edited projects, added Parsoid; removed VisualEditor.

matmarex mentioned this in T111674: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions.Feb 29 2016, 8:46 PM

Interesting ... this looks like some regexp issue in Parsoid.

Yes, confirmed. This is a bug because of the leading space before the pipe. Will fix and add new tests. This will be deployed on Wednesday.

Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.Feb 29 2016, 9:19 PM

Jdforrester-WMF set the point value for this task to 0.

Change 273975 had a related patch set uploaded (by Subramanya Sastry):
T128319: Fix fragile tests for non-block-format transclusions

https://gerrit.wikimedia.org/r/273975

gerritbot added a project: Patch-For-Review.Feb 29 2016, 9:28 PM

• Elitre subscribed.Feb 29 2016, 9:31 PM

Change 273975 merged by jenkins-bot:
T128319: Fix fragile tests for non-block-format transclusions

https://gerrit.wikimedia.org/r/273975

For the first one, it was then fixed by https://fr.wikipedia.org/w/index.php?title=Windows_10&diff=prev&oldid=123794378 later (also via VE and Parsoid). Not quite sure why?

In T128319#2073898, @Jdforrester-WMF wrote:

For the first one, it was then fixed by https://fr.wikipedia.org/w/index.php?title=Windows_10&diff=prev&oldid=123794378 later (also via VE and Parsoid). Not quite sure why?

That is a wikitext edit as far as I can tell.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Mar 1 2016, 12:45 AM

Jdforrester-WMF renamed this task from Lines inserted in “block” format to Extra lines being inserted in edited transclusion wikitext serialisation when “block” format due to unexpected extra spaces.Mar 1 2016, 1:15 AM

Jdforrester-WMF assigned this task to ssastry.

Trizek-WMF subscribed.Mar 1 2016, 3:57 PM

This fix has been deployed.

Extra lines being inserted in edited transclusion wikitext serialisation when “block” format due to unexpected extra spacesClosed, ResolvedPublic0 Estimated Story PointsActions

Description

Related Objects

Event Timeline

Extra lines being inserted in edited transclusion wikitext serialisation when “block” format due to unexpected extra spaces
Closed, ResolvedPublic0 Estimated Story Points
Actions