Maniphest T129571

QuickSurveys could trigger Skin changed class
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Mar 10 2016, 9:45 PM

Tags

Referenced Files

None

Subscribers

View All 9 Subscribers

Description

We could trigger a "changed" event on theSkin object from Extension:QuickSurveys after changing the html content.
(https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.startup/Skin.js#L156-L159)
This would make sure that skin handlers get triggered when the HTML jumps

The only problem is QuickSurveys shouldn't know about the Skin class
We should probably thus make the Skin class use mw.hook and QuickSurveys subscribe to it.

Related Objects

Mentioned In: T126591: Refreshing page with lazy loading images enabled causes images to not load *on load*.
Mentioned Here: T124390: [GOAL] Load images with care

Event Timeline

Jdlrobson created this task.Mar 10 2016, 9:45 PM

Jdlrobson mentioned this in T126591: Refreshing page with lazy loading images enabled causes images to not load *on load*..

Jdlrobson merged a task: T129570: QuickSurveys could trigger Skin changed class.

Jdlrobson removed a parent task: T126591: Refreshing page with lazy loading images enabled causes images to not load *on load*..

Jdlrobson added a parent task: T124390: [GOAL] Load images with care.Mar 10 2016, 9:48 PM

Does this in fact block T124390: [GOAL] Load images with care?

Jdlrobson edited projects, added Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay; removed Reading-Web-Sprint-67-If, Then, Else...?.Mar 11 2016, 6:53 PM

Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Mar 16 2016, 10:33 PM

Krinkle unsubscribed.Mar 16 2016, 11:50 PM

Jdlrobson removed a parent task: T124390: [GOAL] Load images with care.Mar 17 2016, 12:04 AM

dr0ptp4kt edited projects, added Reading-Web-Sprint-70-Lady-and-the-Trumps; removed Reading-Web-Sprint-69-K-Phab-and-the-Kurious-Koders-mmKay.Mar 28 2016, 4:41 PM

dr0ptp4kt added a parent task: T124390: [GOAL] Load images with care.

dr0ptp4kt added a project: QuickSurveys.Apr 11 2016, 2:39 AM

dr0ptp4kt edited projects, added Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters; removed Reading-Web-Sprint-70-Lady-and-the-Trumps.Apr 11 2016, 6:09 PM

Jdlrobson removed a parent task: T124390: [GOAL] Load images with care.Apr 12 2016, 7:42 PM

dr0ptp4kt edited projects, added Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one; removed Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 19 2016, 9:56 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 9:56 PM

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:18 PM

MBinder_WMF moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Apr 27 2016, 4:49 PM

dr0ptp4kt removed a project: Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.May 9 2016, 2:46 PM

dr0ptp4kt moved this task from 2016-17 Q2 to Triaged but Future on the Web-Team-Backlog board.May 20 2016, 11:45 AM

I forget why this was important.