Page MenuHomePhabricator
Create Task
Maniphest T129836

References sections are not expanded anymore when viewing diffs
Closed, ResolvedPublic
Actions

Description

References sections used to be expanded when viewing diffs or independent revisions AFAIK. The behaviour could be changed during last overhaul. Is this coming back?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Introduce ReadModeViewFactory for diffs and old revisionsmediawiki/extensions/Wikibasemaster+142 -45
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sjoerddebruin created this task.Mar 14 2016, 10:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2016, 10:54 AM
Lydia_Pintscher subscribed.Apr 3 2016, 12:21 PM

Can you please add a screenshot of what you mean?

Sjoerddebruin added a comment.Aug 8 2016, 10:06 PM

Oh, missed this. The reference sections were always expanded when viewing pages like https://www.wikidata.org/w/index.php?title=Q18016466&type=revision&diff=349938341&oldid=337222697.

thiemowmde triaged this task as High priority.Aug 10 2016, 4:38 PM
thiemowmde added projects: MediaWiki-extensions-WikibaseView, Wikidata-Sprint-2016-08-02.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde subscribed.

The bug is that the editing UI is initialized on diffs and old revisions. This should not happen. Bug introduced in https://gerrit.wikimedia.org/r/298751.

thiemowmde claimed this task.Aug 10 2016, 4:39 PM
thiemowmde moved this task from Proposed to Doing on the Wikidata-Sprint-2016-08-02 board.
thiemowmde added a subscriber: • Jonas.
gerritbot subscribed.Aug 11 2016, 4:08 PM

Change 304252 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Introduce ReadModeViewFactory for diffs and old revisions

https://gerrit.wikimedia.org/r/304252

gerritbot added a project: Patch-For-Review.Aug 11 2016, 4:08 PM
thiemowmde moved this task from Doing to Review on the Wikidata-Sprint-2016-08-02 board.Aug 11 2016, 4:09 PM
• Jonas closed this task as Resolved.Aug 12 2016, 2:21 PM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-08-02 board.
thiemowmde mentioned this in T146470: [Bug] Editing should be disabled on diffs and old revisions.Sep 23 2016, 12:36 PM
thiemowmde added a parent task: T146470: [Bug] Editing should be disabled on diffs and old revisions.
Sjoerddebruin added a comment.Sep 23 2016, 12:39 PM

The patch is still not merged, I wonder why this is closed as resolved then.

thiemowmde reopened this task as Open.Sep 23 2016, 12:44 PM
thiemowmde added a project: Wikidata-Sprint-2016-09-21.
thiemowmde moved this task from Done to Review on the Wikidata-Sprint-2016-08-02 board.
thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-09-21 board.
gerritbot added a comment.Sep 25 2016, 11:19 PM

Change 304252 merged by jenkins-bot:
Introduce ReadModeViewFactory for diffs and old revisions

https://gerrit.wikimedia.org/r/304252

• Jonas closed this task as Resolved.Sep 27 2016, 10:08 AM
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-09-21 board.
thiemowmde added a project: User-thiemowmde.Dec 19 2017, 1:35 PM
thiemowmde mentioned this in T182767: Can't see references on historic revisions of items on Wikidata.Dec 19 2017, 1:43 PM
MisterSynergy mentioned this in T196423: Can't see references in deleted revisions of items on Wikidata.Jun 5 2018, 5:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits