Page MenuHomePhabricator
Create Task
Maniphest T182767

Can't see references on historic revisions of items on Wikidata
Closed, ResolvedPublic
Actions

Description

You can't expand the revisions on a historic revision of an item on Wikidata like you can on the most current one. This means users can't see how a statement was referenced before.

For example https://www.wikidata.org/w/index.php?title=Q43920918&oldid=599708910

looks like this:

image.png (86×913 px, 6 KB)

compared to the most recent revision:

image.png (111×910 px, 8 KB)

I saw this on Chrome Version 62.0.3202.94 (Official Build) (64-bit) (linux) in incognito mode when not logged in.

Details

SubjectRepoBranchLines +/-
Properly load collapsible sitelinks CSS exactly when neededmediawiki/extensions/Wikibasemaster+37 -29
Remove editable flag in EntityParserOutputGeneratormediawiki/extensions/Wikibasemaster+14 -193
Show references on the diff pagemediawiki/extensions/Wikibasemaster+2 -1
Do not collapse references on diffs/old revisionsmediawiki/extensions/Wikibasemaster+16 -194
Remove default "true" from MissingMediaInfoHandlermediawiki/extensions/WikibaseMediaInfomaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Tarrow created this task.Dec 13 2017, 12:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2017, 12:28 PM
Tarrow updated the task description. (Show Details)Dec 13 2017, 12:32 PM
thiemowmde triaged this task as High priority.Dec 14 2017, 4:31 PM
thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, Regression.
thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board.
thiemowmde added subscribers: Lydia_Pintscher, thiemowmde, Ladsgroup.

I believe this is a fallout from a recent MediaWiki core change that is closely related to T181807. Thanks a lot for reporting this. This indeed needs fixing.

thiemowmde added a project: User-thiemowmde.Dec 19 2017, 1:41 PM
thiemowmde added a comment.Dec 19 2017, 1:43 PM

I just realized this is exactly the same as T129836. I assume the issue came back because of an other reason, that's why I suggest to leave this separate ticket open.

thiemowmde added a project: Wikidata-Sprint-2017-12-20.Dec 19 2017, 2:19 PM

We picked this for Wikidata-Sprint-2017-12-20, but only for investigation. If a fix is trivial it will be submitted right away. Otherwise the result of the investigation will go as a task to the next sprint.

matej_suchanek subscribed.Dec 21 2017, 8:06 PM

I was bold and made a temporary workaround in Common.css.

thiemowmde added a comment.Dec 22 2017, 11:33 AM

Thanks! This CSS workaround gives us time to figure out what happened. Thank you especially for leaving this comment here, this is very helpful.

thiemowmde moved this task from Incoming to TechDebt on the User-thiemowmde board.Dec 29 2017, 9:19 AM
thiemowmde moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-12-20 board.
gerritbot subscribed.Dec 29 2017, 11:08 AM

Change 400684 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Properly load collapsible sitelinks CSS exactly when needed

https://gerrit.wikimedia.org/r/400684

gerritbot added a project: Patch-For-Review.Dec 29 2017, 11:08 AM
gerritbot added a comment.Dec 29 2017, 11:17 AM

Change 400685 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Do not collapse references on diffs/old revisions

https://gerrit.wikimedia.org/r/400685

thiemowmde claimed this task.Dec 29 2017, 11:18 AM
thiemowmde moved this task from In Progress to Review on the Wikidata-Sprint-2017-12-20 board.
thiemowmde moved this task from consider for next sprint to in progress on the Wikidata board.
gerritbot added a comment.Dec 29 2017, 11:20 AM

Change 400686 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove default "true" from MissingMediaInfoHandler

https://gerrit.wikimedia.org/r/400686

thiemowmde mentioned this in rEWBIec24dd8c3b8e: Remove default "true" from MissingMediaInfoHandler.Dec 29 2017, 11:41 AM
gerritbot added a comment.Dec 30 2017, 12:53 PM

Change 400684 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Properly load collapsible sitelinks CSS exactly when needed

https://gerrit.wikimedia.org/r/400684

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 30 2017, 1:00 PM
gerritbot added a comment.Jan 2 2018, 12:04 PM

Change 400685 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Do not collapse references on diffs/old revisions

https://gerrit.wikimedia.org/r/400685

WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2017-12-20 board.Jan 2 2018, 12:06 PM
gerritbot added a comment.Jan 2 2018, 12:19 PM

Change 400686 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove default "true" from MissingMediaInfoHandler

https://gerrit.wikimedia.org/r/400686

WMDE-leszek closed this task as Resolved.Jan 2 2018, 2:29 PM
Lydia_Pintscher added a comment.Jan 2 2018, 2:47 PM

@matej_suchanek can you remove the work-around after tomorrow's deployment?

gerritbot added a comment.Jan 3 2018, 7:41 AM

Change 401695 had a related patch set uploaded (by WMDE-leszek; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Show references on the diff page

https://gerrit.wikimedia.org/r/401695

gerritbot added a comment.Jan 3 2018, 8:19 AM

Change 401695 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Show references on the diff page

https://gerrit.wikimedia.org/r/401695

gerritbot added a comment.Jan 3 2018, 8:45 AM

Change 401699 had a related patch set uploaded (by WMDE-leszek; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove editable flag in EntityParserOutputGenerator

https://gerrit.wikimedia.org/r/401699

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)); removed MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 3 2018, 9:00 AM
gerritbot added a comment.Jan 3 2018, 9:14 AM

Change 401699 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove editable flag in EntityParserOutputGenerator

https://gerrit.wikimedia.org/r/401699

matej_suchanek added a comment.Jan 3 2018, 10:03 PM
In T182767#3867221, @Lydia_Pintscher wrote:

@matej_suchanek can you remove the work-around after tomorrow's deployment?

The fix seems to have been rolled back, disabling the workaround doesn't fix the problem.

Lydia_Pintscher added a comment.Jan 4 2018, 9:31 AM

Jep you're right. It had to be reverted. So let's keep the hack until the fix is back in :)

matej_suchanek removed a project: Patch-For-Review.Jan 11 2018, 7:43 PM
matej_suchanek unsubscribed.
matej_suchanek reopened this task as Open.Jan 13 2018, 2:11 PM

Still not working (workaround necessary).

Ladsgroup added a comment.Jan 13 2018, 2:14 PM

Because it's not live, the train got rollbacked.

matej_suchanek mentioned this in T186006: References aren't readable to unprivileged users on Wikidata when an item is protected.Jan 30 2018, 6:55 PM
thiemowmde closed this task as Resolved.Jan 31 2018, 5:29 PM
thiemowmde removed a project: User-thiemowmde.

Please do not reopen issues that are solved in the code just because the code is not yet rolled out to the live website. I understand that you want to track if you can remove the local workaround. That might need a separate ticket.

MisterSynergy mentioned this in T196423: Can't see references in deleted revisions of items on Wikidata.Jun 5 2018, 5:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL