Page MenuHomePhabricator

account_config vs accountInfo vs account_name is a mess
Open, Needs TriagePublic2 Story Points

Description

...and not just because of the inconsistent naming.

  • we define an array of accounts, but only ever use the first one in the list
  • accountInfo is usually just a subset of values from account_config with renamed keys
  • for gateways that have multiple accounts, we still always set queue message key 'gateway_account' to the key of the first account in the list.

Maybe move all the account stuff into authentication helper objects?

$authenticator->addCredentials( $this, &$staged_data );

The authenticator can fetch the global var, call whatever GatewayType methods it needs to determine the correct account and current txn, and add the appropriate keys and values to the staged data.

Event Timeline

Ejegg created this task.Mar 16 2016, 8:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2016, 8:46 PM
DStrine set the point value for this task to 2.Mar 22 2016, 7:21 PM