Page MenuHomePhabricator

Migrate MobileFrontend npm job to Nodepool
Closed, ResolvedPublic

Description

MobileFrontend 'npm test' fails on Nodepool instance since jsduck is not available there:

00:01:07.900 > MobileFrontend-dependencies@0.0.1 doc /home/jenkins/workspace/npm-node-4.3
00:01:07.900 > jsduck
00:01:07.900 
00:01:07.905 sh: 1: jsduck: not found

Event Timeline

Should most probably use the rake-jessie job instead and jsduck provided via a Gemfile which is T109005.

Change 278857 had a related patch set uploaded (by Hashar):
[MobileFrontend] point to task for npm-legacy

https://gerrit.wikimedia.org/r/278857

Change 278857 merged by jenkins-bot:
[MobileFrontend] point to task for npm-legacy

https://gerrit.wikimedia.org/r/278857

Change 280937 had a related patch set uploaded (by Paladox):
Have npm doc to install jsduck with bundler

https://gerrit.wikimedia.org/r/280937

Change 281934 had a related patch set uploaded (by Hashar):
[MobileFronted] switch npm job to Nodepool

https://gerrit.wikimedia.org/r/281934

Change 281934 merged by jenkins-bot:
[MobileFronted] switch npm job to Nodepool

https://gerrit.wikimedia.org/r/281934

Change 281937 had a related patch set uploaded (by Hashar):
Have npm doc to install jsduck with bundler

https://gerrit.wikimedia.org/r/281937

Change 281938 had a related patch set uploaded (by Hashar):
Have npm doc to install jsduck with bundler

https://gerrit.wikimedia.org/r/281938

hashar claimed this task.

Fixed by:

  • adding a 'predoc' script that runs 'bundle install'
  • changing the 'doc script' to run 'bundle exec jsduck'

Cherry picked to both wmf branches.

Change 280937 merged by jenkins-bot:
Have npm doc to install jsduck with bundler

https://gerrit.wikimedia.org/r/280937

Change 281938 merged by jenkins-bot:
Have npm doc to install jsduck with bundler

https://gerrit.wikimedia.org/r/281938

Change 281937 merged by jenkins-bot:
Have npm doc to install jsduck with bundler

https://gerrit.wikimedia.org/r/281937