There is special code in the CI to handle the submodules of the VisualEditor Mediawiki extension. We should generalize that for all extensions or make VisualEditor stop using submodules.
This task was created after: https://gerrit.wikimedia.org/r/#/c/262432/
See also: T51846
List of potentially affected extensions:
$ cd projects/mediawiki/extensions $ ls -1 */.gitmodules|cut -d\/ -f1
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | PRODUCTION ERROR | hashar | T155773 LinkSuggest2 test failing due to missing files located in sub repo | ||
| Resolved | PRODUCTION ERROR | hashar | T154930 PagesList tests failing due to missing files located in sub repo | ||
| Resolved | PRODUCTION ERROR | Paladox | T154848 GooglePlaces tests failing due to missing files located in sub repo | ||
| Resolved | PRODUCTION ERROR | Paladox | T154847 FlickrAPI test failing due to missing files located in sub repo | ||
| Resolved | PRODUCTION ERROR | hashar | T154806 Skin Refreshed sub repo does not handled in test config | ||
| Resolved | PRODUCTION ERROR | hashar | T154935 PaginateText extension: Tests failing due to missing files located in sub repo | ||
| Resolved | hashar | T130966 generalize extension submodule handling | |||
| Declined | hashar | T84942 Zuul-cloner should check out submodules |
We had T84942 to add submodule support in zuul-cloner.
We do process the submodule for mediawiki/extensions/VisualEditor via a hack in the Jenkins job configuration:
# Workaround zuul-cloner not processing submodules - builder: name: ve-submodules-update builders: - shell: | if grep -q mediawiki/extensions/VisualEditor deps.txt; then cd src/extensions/VisualEditor git submodule foreach git clean -xdff -q git submodule update --init git submodule status fi
An alternative is to glob all extensions/skins and run the above command whenever there is a .gitmodules file. That would fix it for all repos.
Change 369642 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Process extensions and skins submodules
Change 369642 merged by jenkins-bot:
[integration/config@master] Process extensions and skins submodules
Change 369647 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Make some extensions jobs voting
Change 369649 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Process git modules recursively
Change 369649 merged by jenkins-bot:
[integration/config@master] Process git modules recursively
Change 369647 merged by jenkins-bot:
[integration/config@master] Make some extensions jobs voting
extensions and skins now have their submodules process recursively.
That fixed Widgets and probably some of the parent tasks as well.