Page MenuHomePhabricator
Create Task
Maniphest T154847

FlickrAPI test failing due to missing files located in sub repo
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

The FlickrAPI extension has a sub repo phpflickr, which is not known by the test framework and such this gives error when test are running:

15:10:48 There was 1 failure:
15:10:48 
15:10:48 1) AutoLoaderTest::testAutoLoadConfig
15:10:48 Failed asserting that two arrays are equal.
15:10:48 --- Expected
15:10:48 +++ Actual
15:10:48 @@ @@
15:10:48      'FlickrAPICache' => '/srv/jenkins-workspace/worksp...he.php'
15:10:48 -    'phpFlickr' => '/srv/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/FlickrAPI/modules/phpflickr/phpFlickr.php'
15:10:48 +    'phpFlickr' => '[file '/srv/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/FlickrAPI/modules/phpflickr/phpFlickr.php' does not exist]'
15:10:48      'TestSetup' => '/srv/jenkins-workspace/worksp...up.php'
15:10:48      'MWHttpRequestTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'DbTestPreviewer' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'DbTestRecorder' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'DjVuSupport' => '/srv/jenkins-workspace/worksp...rt.php'
15:10:48      'MultiTestRecorder' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'ParserTestMockParser' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'ParserTestRunner' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'ParserTestParserHook' => '/srv/jenkins-workspace/worksp...ok.php'
15:10:48      'ParserTestPrinter' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'ParserTestResult' => '/srv/jenkins-workspace/worksp...lt.php'
15:10:48      'ParserTestResultNormalizer' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'PhpunitTestRecorder' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'TestFileEditor' => '/srv/jenkins-workspace/worksp...or.php'
15:10:48      'TestFileReader' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'TestRecorder' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'TidySupport' => '/srv/jenkins-workspace/worksp...rt.php'
15:10:48      'MediaWikiTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'MediaWikiPHPUnitTestListener' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'MediaWikiLangTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'ResourceLoaderTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'ResourceLoaderTestModule' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'ResourceLoaderFileModuleTestModule' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'EmptyResourceLoader' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'TestUser' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'TestUserRegistry' => '/srv/jenkins-workspace/worksp...ry.php'
15:10:48      'LessFileCompilationTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'RevisionStorageTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'TestingAccessWrapper' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'TestLogger' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'ApiFormatTestBase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'ApiQueryTestBase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'ApiQueryContinueTestBase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'ApiTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'ApiTestCaseUpload' => '/srv/jenkins-workspace/worksp...ad.php'
15:10:48      'ApiTestContext' => '/srv/jenkins-workspace/worksp...xt.php'
15:10:48      'MockApi' => '/srv/jenkins-workspace/worksp...pi.php'
15:10:48      'MockApiQueryBase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'UserWrapper' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'RandomImageGenerator' => '/srv/jenkins-workspace/worksp...or.php'
15:10:48      'MediaWiki\Auth\AuthenticationRequestTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'TestRecentChangesHelper' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'DummyContentHandlerForTesting' => '/srv/jenkins-workspace/worksp...ng.php'
15:10:48      'DummyContentForTesting' => '/srv/jenkins-workspace/worksp...ng.php'
15:10:48      'DummyNonTextContentHandler' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'DummyNonTextContent' => '/srv/jenkins-workspace/worksp...nt.php'
15:10:48      'ContentHandlerTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'JavaScriptContentTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'TextContentTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'WikitextContentTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'DatabaseTestHelper' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'FakeDiffOp' => '/srv/jenkins-workspace/worksp...Op.php'
15:10:48      'LogFormatterTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'WikiPageTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'ParserIntegrationTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'PasswordTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'ResourceLoaderImageModuleTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'ResourceLoaderImageModuleTestable' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'MediaWiki\Session\TestBagOStuff' => '/srv/jenkins-workspace/worksp...ff.php'
15:10:48      'MediaWiki\Session\TestUtils' => '/srv/jenkins-workspace/worksp...ls.php'
15:10:48      'SiteTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'TestSites' => '/srv/jenkins-workspace/worksp...es.php'
15:10:48      'SpecialPageTestHelper' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'SpecialPageTestBase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'SpecialPageExecutor' => '/srv/jenkins-workspace/worksp...or.php'
15:10:48      'LanguageClassesTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'GenericArrayObjectTest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'DumpTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'FakeDimensionFile' => '/srv/jenkins-workspace/worksp...le.php'
15:10:48      'MediaWikiMediaTestCase' => '/srv/jenkins-workspace/worksp...se.php'
15:10:48      'MockFSFile' => '/srv/jenkins-workspace/worksp...le.php'
15:10:48      'MockFileBackend' => '/srv/jenkins-workspace/worksp...nd.php'
15:10:48      'MockLocalRepo' => '/srv/jenkins-workspace/worksp...po.php'
15:10:48      'MockBitmapHandler' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'MockImageHandler' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'MockSvgHandler' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'MockDjVuHandler' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'MockOggHandler' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'MockMediaHandlerFactory' => '/srv/jenkins-workspace/worksp...ry.php'
15:10:48      'MockWebRequest' => '/srv/jenkins-workspace/worksp...st.php'
15:10:48      'MediaWiki\Session\DummySessionBackend' => '/srv/jenkins-workspace/worksp...nd.php'
15:10:48      'DummySessionProvider' => '/srv/jenkins-workspace/worksp...er.php'
15:10:48      'ParserTestFileSuite' => '/srv/jenkins-workspace/worksp...te.php'
15:10:48      'ParserTestTopLevelSuite' => '/srv/jenkins-workspace/worksp...te.php'
15:10:48      'TestAutoloadedClass' => '/srv/jenkins-workspace/worksp...ss.php'
15:10:48  )

Details

SubjectRepoBranchLines +/-
Make some extension votingintegration/configmaster+6 -11
Add missing classes to autoloadermediawiki/extensions/FlickrAPImaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Jan 7 2017, 3:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2017, 3:16 PM
Umherirrender renamed this task from F to FlickrAPI test failing due to missing files located in sub repo.Jan 7 2017, 3:19 PM
Umherirrender added projects: MediaWiki-extensions-General, Continuous-Integration-Config, MediaWiki-Core-Tests.
Umherirrender updated the task description. (Show Details)
Umherirrender added a comment.Jan 7 2017, 3:45 PM

One solution is to bundle the files with the extension, makes install easier. See T154806 for a discussion about this problem on another repo

Aklapper edited projects, added MediaWiki-extensions-Other; removed MediaWiki-extensions-General.Jan 8 2017, 8:39 PM
Reedy subscribed.Jan 9 2017, 1:27 AM
	url = https://github.com/dan-coulter/phpflickr.git

https://packagist.org/packages/zgetro/phpflickr seems to be a packagist import (few commits ahead of that repo, adding the composer.json etc

Umherirrender added a parent task: T134090: fix or mark as inactive extensions currently failing CI.Jan 19 2017, 8:46 PM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:10 AM
Krinkle removed a project: MediaWiki-Core-Tests.
hashar added a subtask: T130966: generalize extension submodule handling.Jul 18 2017, 1:02 PM
hashar mentioned this in T130966: generalize extension submodule handling.Jul 18 2017, 1:11 PM
hashar closed subtask T130966: generalize extension submodule handling as Resolved.Aug 2 2017, 1:51 PM
hashar subscribed.Aug 2 2017, 2:05 PM

submodules are now process (T130966). Now fails with:

13:59:50 1) AutoLoaderTest::testAutoLoadConfig
13:59:50 Failed asserting that two arrays are equal.
13:59:50 --- Expected
13:59:50 +++ Actual
13:59:50 @@ @@
13:59:50 'TestAutoloadedClass' => '/home/jenkins/workspace/mwext...ss.php'
13:59:50 + 'phpFlickr_pager' => '/home/jenkins/workspace/mwext...kr.php'
13:59:50 )
13:59:50

gerritbot subscribed.Aug 2 2017, 2:09 PM

Change 369656 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/FlickrAPI@master] Add missing classes to autoloader

https://gerrit.wikimedia.org/r/369656

gerritbot added a project: Patch-For-Review.Aug 2 2017, 2:09 PM
gerritbot added a comment.Aug 2 2017, 2:14 PM

Change 369659 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Make some extension voting

https://gerrit.wikimedia.org/r/369659

gerritbot added a comment.Aug 2 2017, 2:15 PM

Change 369656 merged by jenkins-bot:
[mediawiki/extensions/FlickrAPI@master] Add missing classes to autoloader

https://gerrit.wikimedia.org/r/369656

Paladox closed this task as Resolved.Aug 2 2017, 2:15 PM
Paladox claimed this task.
gerritbot added a comment.Aug 2 2017, 2:17 PM

Change 369659 merged by jenkins-bot:
[integration/config@master] Make some extension voting

https://gerrit.wikimedia.org/r/369659

Umherirrender added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 13 2018, 7:20 PM
Umherirrender removed a parent task: T134090: fix or mark as inactive extensions currently failing CI.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Peachey88 edited projects, added MediaWiki-extensions-FlickrAPI; removed MediaWiki-extensions-Other.May 6 2022, 8:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits