Page MenuHomePhabricator

PaginateText extension: Tests failing due to missing files located in sub repo
Closed, ResolvedPublicPRODUCTION ERROR

Description

PaginateText has a sub repo jquery_textpager, which is not known by the test framework and such this gives error when tests are running:

19:40:20 There was 1 failure:
19:40:20 
19:40:20 1) ResourcesTest::testFileExistence with data set #555 ('/srv/jenkins-workspace/worksp...ger.js', 'ext.PaginateText.TextPager', 'modules/jquery_textpager/jque...ger.js')
19:40:20 File 'modules/jquery_textpager/jquery.textpager.js' referenced by 'ext.PaginateText.TextPager' must exist.
19:40:20 Failed asserting that file "/srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/extensions/PaginateText/modules/jquery_textpager/jquery.textpager.js" exists.
19:40:20 
19:40:20 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/structure/ResourcesTest.php:23
19:40:20 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/tests/phpunit/MediaWikiTestCase.php:399
19:40:20 /srv/jenkins-workspace/workspace/mwext-testextension-hhvm-composer/src/maintenance/doMaintenance.php:111
19:40:20 
19:40:20 FAILURES!

One solution is to bundle the files with the extension, makes install easier. See T154806 for a discussion about this problem on another repo

Event Timeline

Krinkle renamed this task from PaginateText tests failing due to missing files located in sub repo to PaginateText extension: Tests failing due to missing files located in sub repo.Jul 7 2017, 5:09 AM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
Krinkle removed a project: MediaWiki-Core-Tests.

Change 369659 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Make some extension voting

https://gerrit.wikimedia.org/r/369659

Change 369659 merged by jenkins-bot:
[integration/config@master] Make some extension voting

https://gerrit.wikimedia.org/r/369659

hashar claimed this task.
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM