Page MenuHomePhabricator
Create Task
Maniphest T131757

Remove mobile.special.mobilediff.scripts
Closed, ResolvedPublic
Actions

Description

Some logging schemas are being removed in https://gerrit.wikimedia.org/r/#/c/273456 and the mobile.special.mobilediff.scripts module is being kept in order not to break anything in production if we wish to revert some changes. Let's remove mobile.special.mobilediff.scripts 2 weeks after we push the above patch to production.

Acceptance criteria:

  • Remove mobile.special.mobilediff.scripts module from extension.json
  • Remove mobile.special.mobilediff.scripts module folder and files

Details

SubjectRepoBranchLines +/-
Remove mobile.special.mobilediff.scripts from extension.jsonmediawiki/extensions/MobileFrontendmaster+0 -8
Remove mobile.special.mobilediff.scripts dependencymediawiki/extensions/Thanksmaster+0 -1
Customize query in gerrit

Event Timeline

• bmansurov created this task.Apr 4 2016, 12:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2016, 12:24 PM
• bmansurov updated the task description. (Show Details)Apr 4 2016, 12:47 PM
phuedx triaged this task as Medium priority.Apr 7 2016, 5:08 PM
phuedx added a project: Reading-Web-Sprint-70-Lady-and-the-Trumps.
phuedx edited projects, added Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters; removed Reading-Web-Sprint-70-Lady-and-the-Trumps.Apr 7 2016, 5:11 PM
dr0ptp4kt edited projects, added Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one; removed Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 19 2016, 9:55 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 9:55 PM
MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:18 PM
MBinder_WMF moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Apr 27 2016, 4:49 PM
Jdlrobson edited projects, added Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card; removed Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.May 9 2016, 4:54 PM
dr0ptp4kt removed a project: Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card.May 11 2016, 5:01 PM
Jdlrobson subscribed.May 12 2016, 3:45 PM

Special pages are not subject to cache so I'm not sure I understand the 2 week delay...

• bmansurov added a comment.May 12 2016, 4:02 PM

I think the reasoning was that in case we wanted to revert, it would be easier.

dr0ptp4kt moved this task from 2016-17 Q2 to Triaged but Future on the Web-Team-Backlog board.May 20 2016, 11:46 AM
gerritbot subscribed.Jun 18 2016, 8:03 PM

Change 295043 had a related patch set uploaded (by Mholloway):
Remove mobile.special.mobilediff.scripts from extensions.json

https://gerrit.wikimedia.org/r/295043

gerritbot added a project: Patch-For-Review.Jun 18 2016, 8:03 PM
gerritbot added a comment.Jun 18 2016, 9:03 PM

Change 295098 had a related patch set uploaded (by Mholloway):
Remove mobile.special.mobilediff.scripts dependency

https://gerrit.wikimedia.org/r/295098

• bmansurov closed this task as Resolved.Jun 19 2016, 8:44 PM
• bmansurov claimed this task.
• bmansurov added a subscriber: • Mholloway.

Thanks, @Mholloway!

• bmansurov removed • bmansurov as the assignee of this task.Jun 19 2016, 8:45 PM
gerritbot added a comment.Jun 19 2016, 8:52 PM

Change 295098 merged by jenkins-bot:
Remove mobile.special.mobilediff.scripts dependency

https://gerrit.wikimedia.org/r/295098

gerritbot added a comment.Jun 19 2016, 8:53 PM

Change 295043 merged by jenkins-bot:
Remove mobile.special.mobilediff.scripts from extension.json

https://gerrit.wikimedia.org/r/295043

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-21_(1.28.0-wmf.7)).Jun 19 2016, 9:00 PM
• Phabricator_maintenance moved this task from Triaged but Future to 2015-16 Q4 on the Web-Team-Backlog board.Mar 6 2018, 11:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits