Page MenuHomePhabricator
Create Task
Maniphest T131975

Add confirmation feature to Nuke extension
Closed, ResolvedPublic
Actions

Description

Please add the most annoying feature in MediaWiki (CAPTCHA) to the place it should be - Nuke.
Administrators can accidentally cause massive damage (as already happened too many times), and it is important to let them confirm in a more than safe way that they are sure

Details

SubjectRepoBranchLines +/-
Fix broken message showing {{PLURAL:…}} in plain textmediawiki/extensions/Nukemaster+4 -1
Fix wrong use of mw.msgmediawiki/extensions/Nukemaster+1 -1
Ask for confirmation when nukingmediawiki/extensions/Nukemaster+30 -3
Customize query in gerrit

Related Objects

Event Timeline

eranroz created this task.Apr 6 2016, 9:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2016, 9:03 PM
Jackmcbarn subscribed.Apr 6 2016, 9:15 PM

CAPTCHA isn't meant to be "Are you sure". It's meant to be "Are you a human". If you want a bigger confirmation step, please ask for something different (like typing the username of the user to nuke again).

Aklapper renamed this task from CAPTCHA for NUKE to Add CAPTCHA feature to Nuke extension.Apr 7 2016, 8:46 AM
gerritbot subscribed.Dec 28 2016, 8:16 AM

Change 329387 had a related patch set uploaded (by Ladsgroup):
Ask for confirmation when nuking

https://gerrit.wikimedia.org/r/329387

gerritbot added a project: Patch-For-Review.Dec 28 2016, 8:16 AM
Ladsgroup subscribed.Dec 28 2016, 8:17 AM

I added a patch which makes Nuke asks for confirmation. CAPTCHA would be too much as pointed out by @Jackmcbarn

IKhitron added a comment.Dec 28 2016, 9:29 AM

@Ladsgroup, please, add the number of deleted pages into the confirmation message. The problem is almost always when somebody wants to delete five pages but deletes five hundred. Thank you.

Ladsgroup added a comment.Dec 29 2016, 7:33 AM
In T131975#2904609, @IKhitron wrote:

@Ladsgroup, please, add the number of deleted pages into the confirmation message. The problem is almost always when somebody wants to delete five pages but deletes five hundred. Thank you.

Done

IKhitron added a comment.Dec 29 2016, 10:42 AM

Thanks a lot.

gerritbot added a comment.Oct 6 2017, 10:06 AM

Change 329387 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Ask for confirmation when nuking

https://gerrit.wikimedia.org/r/329387

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 6 2017, 11:00 AM
Jdforrester-WMF renamed this task from Add CAPTCHA feature to Nuke extension to Add confirmation feature to Nuke extension.Oct 6 2017, 5:27 PM
Jdforrester-WMF assigned this task to Ladsgroup.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptOct 6 2017, 5:27 PM
Jdforrester-WMF closed this task as Resolved.Oct 6 2017, 5:28 PM
IKhitron added a subscriber: Jdforrester-WMF.EditedDec 22 2017, 1:54 PM

Hi, @Ladsgroup, @Jdforrester-WMF. I just used Nuke first time from this task was closed, and I did not see any confirmation message, the pages just were deleted. Tryed a couple of times on hewiki. Thank you.

gerritbot added a comment.Jan 21 2018, 8:57 PM

Change 405602 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Nuke@master] Fix wrong use of mw.msg

https://gerrit.wikimedia.org/r/405602

gerritbot added a project: Patch-For-Review.Jan 21 2018, 8:57 PM
Ladsgroup added a comment.Jan 21 2018, 8:57 PM

Sorry, I made an oversight about this. It's fixed by this patch that I hope I can get merged soon.

gerritbot added a comment.Jan 21 2018, 9:15 PM

Change 405602 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Fix wrong use of mw.msg

https://gerrit.wikimedia.org/r/405602

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Jan 21 2018, 10:00 PM
gerritbot added a comment.Dec 11 2018, 3:53 PM

Change 478967 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Nuke@master] Fix broken message showing {{PLURAL:…}} in plain text

https://gerrit.wikimedia.org/r/478967

gerritbot added a comment.Dec 11 2018, 5:08 PM

Change 478967 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Fix broken message showing {{PLURAL:…}} in plain text

https://gerrit.wikimedia.org/r/478967

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 11 2018, 6:00 PM
Seb35 mentioned this in T179502: Error : Uncaught TypeError: mw.msg(...).txt is not a function when using Special:Nuke on Commons.Oct 4 2019, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL