Page MenuHomePhabricator

HTTPS redirects for datasets.wikimedia.org
Closed, ResolvedPublic

Description

Enabling this is trivial, the question is: is there any reason we *can't* enable this? Who's responsible for this service and might know of exceptions like mixed-content, or HTTPS-incapable tools which rely on it, etc? [note this a generic message being tacked into the description of several similar tickets]

Details

Related Gerrit Patches:
operations/puppet : productiondatasets: rewrite http to https

Related Objects

StatusAssignedTask
Resolvedema
OpenBBlack
OpenBBlack
ResolvedBBlack
ResolvedArielGlenn
ResolvedChmarkine
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedCCogdill_WMF
DeclinedBBlack
DuplicateBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack
ResolvedBBlack

Event Timeline

BBlack created this task.Apr 12 2016, 3:43 PM
Dzahn edited subscribers, added: ArielGlenn; removed: JohnLewis.

dumps.wm.o already redirects and so does downloads.wm.o. What's left?

BBlack added a comment.EditedApr 12 2016, 9:18 PM

This isn't for dumps or downloads, this is for http://datasets.wikimedia.org

How does that not redirect already? I thought/hoped that the 'default' parameter in the nginx conf on datasets would take care of that. https://gerrit.wikimedia.org/r/#/c/278861/6/modules/dumps/templates/nginx.dumps.conf.erb Anyways, yes please redirect it all!

Change 283084 had a related patch set uploaded (by Dzahn):
datasets: rewrite http to https

https://gerrit.wikimedia.org/r/283084

Dzahn added a comment.Apr 12 2016, 9:38 PM

How does that not redirect already? I thought/hoped that the 'default' parameter in the nginx conf on datasets would take care of that.

Nope, all the services that do this have a rule in the backend based on RewriteCond %{HTTP:X-Forwarded-Proto} !https

https://gerrit.wikimedia.org/r/#/c/283084/1/modules/statistics/files/datasets.wikimedia.org

Dzahn added a comment.Apr 12 2016, 9:39 PM

Somewhat counterintuitively the config for this is not in module dataset but instead in modules/statistics/files/ and it's not nginx but Apache?

That just can't be true. And yet it is. 2d1fa5938f22c94324435c75acc4f496c1cacaa3 @Ottomata set it up. Someone has to ask him about this, I have zero idea.

Dzahn added a comment.EditedApr 12 2016, 9:47 PM

Hah, and that says **"# NOTE: This class has nothing to do with the # datasets site hosted at 'datasets.wikimedia.org'." ** ? ?

Change 283084 abandoned by Dzahn:
datasets: rewrite http to https

Reason:
can be done in varnish

https://gerrit.wikimedia.org/r/283084

datasets.wikimedia.or is hosted on stat1001, not a dataset100x host.

I think HTTPS only is fine, but maybe @Milimetric or @mforns or @Halfak might have more to say.

+1 for HTTPS only being OK.

Change 283207 had a related patch set uploaded (by BBlack):
datasets.wm.o HTTPS redirect T132463

https://gerrit.wikimedia.org/r/283207

Change 283207 merged by BBlack:
datasets.wm.o HTTPS redirect T132463

https://gerrit.wikimedia.org/r/283207

BBlack closed this task as Resolved.Apr 13 2016, 3:43 PM
BBlack claimed this task.