Page MenuHomePhabricator
Create Task
Maniphest T132954

Gracefully handle outdated echo_unread_wikis rows when a notification type has changed categories (alert->message or v.v.)
Closed, ResolvedPublic
Actions

Description

When a notification type is changed from being an alert to a message (e.g. because of T123018), we will get glitchy cross-wiki notifications behavior:

  1. User receives a thanks notification on frwiki. Thanks is an alert, so we store (frwiki, 1, 0) in the database
  2. Thanks changes from being an alert to being a message
  3. User views notifications on enwiki.
    • In the alerts section, a cross-wiki bundle appears with "1 alert from frwiki". Opening this bundle will show nothing, because there are no alerts on frwiki.
    • In the messages section, no cross-wiki bundle appears, so the user cannot access the thanks notification at all.
  4. A maintenance script rebuilds the table, or the user receives another frwiki notification; this changes the row to (frwiki, 0, 1) and things work correctly again.

The intermediate state in #3 is a problem, and would potentially persist for weeks. We could work around this by checking if a transition config flag is set, and if it is, looking at both alerts and messages on each foreign wiki (even if the table has a 0 in that column). This would be hard to do with our current client-side fetch setup, but easier with T130636: Cross-wiki notifications: Make cross-wiki API requests server-side.

Details

SubjectRepoBranchLines +/-
Define global transition vars before using themmediawiki/extensions/Echomaster+2 -0
Gracefully handle outdated echo_unread_wikis rowsmediawiki/extensions/Echomaster+218 -21
Enable Echo transition flags in beta labs for testingoperations/mediawiki-configmaster+4 -0
Implement backfillUnreadWikis.php in terms of resetNotificationCount()mediawiki/extensions/Echomaster+11 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Apr 18 2016, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2016, 6:50 PM
Catrope added a subtask: T130636: Cross-wiki notifications: Make cross-wiki API requests server-side.Apr 18 2016, 6:50 PM
Catrope added a parent task: T130655: Enable cross-wiki notifications by default.Apr 18 2016, 7:00 PM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.Apr 19 2016, 12:58 AM
• Mattflaschen-WMF subscribed.Apr 25 2016, 6:06 PM
• jmatazzoni removed a parent task: T130655: Enable cross-wiki notifications by default.Apr 27 2016, 5:50 PM
• jmatazzoni added a parent task: T133220: Sort out Notification categories to make them more logical for Preferences.
Catrope removed a parent task: T133220: Sort out Notification categories to make them more logical for Preferences.Apr 27 2016, 6:01 PM
• jmatazzoni added a parent task: T123018: Revise Sorting of Notifications on the Fly-Out Menus.Apr 27 2016, 6:01 PM
• jmatazzoni closed subtask T130636: Cross-wiki notifications: Make cross-wiki API requests server-side as Resolved.May 6 2016, 4:38 PM
• jmatazzoni mentioned this in T123018: Revise Sorting of Notifications on the Fly-Out Menus.May 12 2016, 12:05 AM
MGChecker subscribed.May 12 2016, 11:25 AM
SBisson subscribed.May 16 2016, 4:51 PM
  1. User views notifications on enwiki.
  • In the alerts section, a cross-wiki bundle appears with "1 alert from frwiki". Opening this bundle will show nothing, because there are no alerts on frwiki.

A foreign source that ends up being empty is removed. (handled in https://gerrit.wikimedia.org/r/#/c/288649/)

  • In the messages section, no cross-wiki bundle appears, so the user cannot access the thanks notification at all.

What do we want to see in this case?

• Mattflaschen-WMF added a comment.May 16 2016, 5:54 PM

The idea is that in transition mode, the client (which is now the server side of the local wiki) will check the current type of all notifications, and re-sort them.

So after seeing, "1 unread alert, 0 unread messages from frwiki", it will query to get the actual "alert". Then, it will see, "1 thanks from frwiki", then check the current type of thanks, then get "1 message from frwiki". This dynamic re-sorting is temporary until the new sorting scheme is final on all wikis.

gerritbot subscribed.May 29 2016, 9:00 PM

Change 291676 had a related patch set uploaded (by Catrope):
[WIP] Gracefully handle outdated echo_unread_wikis rows

https://gerrit.wikimedia.org/r/291676

gerritbot added a project: Patch-For-Review.May 29 2016, 9:00 PM
Catrope claimed this task.May 29 2016, 9:00 PM
Catrope moved this task from Ready for Pickup to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.
gerritbot added a comment.Jun 8 2016, 2:17 PM

Change 293314 had a related patch set uploaded (by Catrope):
Implement backfillUnreadWikis.php in terms of resetNotificationCount()

https://gerrit.wikimedia.org/r/293314

Catrope added a comment.EditedJun 8 2016, 2:19 PM
In T132954#2364486, @gerritbot wrote:

Change 293314 had a related patch set uploaded (by Catrope):
Implement backfillUnreadWikis.php in terms of resetNotificationCount()

https://gerrit.wikimedia.org/r/293314

We need this because if this script makes changes to echo_unread_wikis, it also needs to update cached count values that are based on this table.

gerritbot added a comment.Jun 11 2016, 3:54 PM

Change 293314 merged by jenkins-bot:
Implement backfillUnreadWikis.php in terms of resetNotificationCount()

https://gerrit.wikimedia.org/r/293314

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)).Jun 11 2016, 4:00 PM
gerritbot added a comment.Jun 20 2016, 3:49 PM

Change 295234 had a related patch set uploaded (by Catrope):
Enable Echo transition flags in beta labs for testing

https://gerrit.wikimedia.org/r/295234

gerritbot added a comment.Jun 20 2016, 3:50 PM

Change 295234 merged by jenkins-bot:
Enable Echo transition flags in beta labs for testing

https://gerrit.wikimedia.org/r/295234

gerritbot added a comment.Jun 20 2016, 3:51 PM

Change 291676 merged by jenkins-bot:
Gracefully handle outdated echo_unread_wikis rows

https://gerrit.wikimedia.org/r/291676

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-21_(1.28.0-wmf.7)).Jun 20 2016, 4:00 PM
Catrope moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 20 2016, 4:47 PM
gerritbot added a comment.Jun 21 2016, 12:01 PM

Change 295335 had a related patch set uploaded (by Sbisson):
Define global transition vars before using them

https://gerrit.wikimedia.org/r/295335

gerritbot added a comment.Jun 21 2016, 12:10 PM

Change 295335 merged by jenkins-bot:
Define global transition vars before using them

https://gerrit.wikimedia.org/r/295335

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)).Jun 22 2016, 5:00 AM
Etonkovidova subscribed.Jun 24 2016, 10:23 PM

Checked in betalabs - re-categorized notifications count/bundle opening runs smoothly and correctly.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jun 24 2016, 10:23 PM
• jmatazzoni closed this task as Resolved.Jul 5 2016, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL