GatewayFormChooser should prefer AstroPay over GlobalCollect, for countries where it's available. This can be set in DonationInterfaceFormSettings.php.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Use selection weights deterministically | mediawiki/extensions/DonationInterface | master | +20 -19 |
Event Timeline
Here's an example of form selection failure:
https://payments.wikimedia.org/index.php/Special:GatewayFormChooser?utm_medium=sitenotice&utm_campaign=&utm_source=B1516_0404_nlNL_dsk_p2_sm_txt_cnt.no-LP.cc&utm_key=0&language=en&country=CL¤cy_code=CLP&payment_method=cc&payment_submethod=&recurring=&gateway=&ffname=&bannerhistlog=&frequency=onetime&amount=28&amountGiven=&testGetAll=true
This selects email-cc-vm, when it should select astropay.
FWIW I refreshed that link a few times and got different results: email-cc-vm, cc-vm, and astropay-cl.
Uh, oh... selection is non-deterministic. Rather than take the form with the greatest weight, we roll a die and use weights as the chance of selecting each form.
We're now appending a gateway=astropay parameter for these countries from banners and donatewiki (which I just fixed). So fixing this in GatewayFormChooser isn't needed before we launch, although it would be nice.
Change 284503 had a related patch set uploaded (by Awight):
Use selection weights deterministically