Page MenuHomePhabricator
Create Task
Maniphest T133728

Duplicate get(): "mediawikiwiki:abusefilter:block-autopromote:xxxx" fetched 3 times
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

AbuseFilter fetches keys more than once from Redis triggering warnings.

Duplicate get(): "" fetched {count} times

KeyCount
"mediawikiwiki:abusefilter:block-autopromote"3 times
"mediawikiwiki:abusefilter:stats:total:default"2 times

Details

SubjectRepoBranchLines +/-
Make negative process caching in onGetAutoPromoteGroups() workmediawiki/extensions/AbuseFiltermaster+2 -2
Avoid duplicate autopromote block key fetchesmediawiki/extensions/AbuseFiltermaster+9 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Apr 26 2016, 7:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2016, 7:14 PM
hashar updated the task description. (Show Details)Apr 26 2016, 7:15 PM
hashar added a parent task: T128543: Hunt down duplicate memcached gets.Apr 26 2016, 7:18 PM
gerritbot subscribed.Apr 30 2016, 9:30 PM

Change 286288 had a related patch set uploaded (by Aaron Schulz):
Avoid duplicate autopromote block key fetches

https://gerrit.wikimedia.org/r/286288

gerritbot added a project: Patch-For-Review.Apr 30 2016, 9:30 PM
gerritbot added a comment.May 6 2016, 11:10 PM

Change 286288 merged by jenkins-bot:
Avoid duplicate autopromote block key fetches

https://gerrit.wikimedia.org/r/286288

Amire80 moved this task from Backlog to Logging on the AbuseFilter board.May 8 2016, 8:57 AM
Amire80 moved this task from Logging to Backlog on the AbuseFilter board.
Amire80 moved this task from Backlog to Internal bugs on the AbuseFilter board.May 8 2016, 9:04 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 10 2016, 1:11 PM
gerritbot added a comment.May 16 2016, 7:03 PM

Change 288755 had a related patch set uploaded (by Aaron Schulz):
Make negative process caching in onGetAutoPromoteGroups() work

https://gerrit.wikimedia.org/r/288755

gerritbot added a comment.May 17 2016, 1:08 AM

Change 288755 merged by jenkins-bot:
Make negative process caching in onGetAutoPromoteGroups() work

https://gerrit.wikimedia.org/r/288755

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)).May 17 2016, 2:00 AM
matmarex closed this task as Resolved.Jul 15 2016, 9:34 PM
matmarex assigned this task to aaron.
matmarex subscribed.

No logstash hits for "abusefilter:stats:total:default" or "abusefilter:block-autopromote" in last 24 hours, presumed fixed.

matmarex reopened this task as Open.Jul 15 2016, 10:18 PM

Actually, logstash lied to me, "abusefilter:stats:total:default" is still happening.

aaron removed aaron as the assignee of this task.Jul 17 2016, 3:01 AM
aaron subscribed.
hashar closed this task as Resolved.Nov 25 2016, 9:13 AM
hashar claimed this task.

Over the last 24 hours, I can not find any "Duplicate get()" messages in Logstash nor is there any message for abusefilter:stats:total:default. So I guess AbuseFilter got definitely fixed.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits