Page MenuHomePhabricator

printableversion link in toolbox does not take viewed revision into account
Closed, DeclinedPublic

Description

Naively accessing the printable view takes you to the printable view of the newest article version, even if you start from an older version.

To recreate
go to : https://sv.wikipedia.org/w/index.php?title=G%C3%B6taland&oldid=1247
click: on the printableversion/Printable version link in the toolbox
actual result: https://sv.wikipedia.org/w/index.php?title=G%C3%B6taland&printable=yes
expected result: https://sv.wikipedia.org/w/index.php?title=G%C3%B6taland&oldid=1247&printable=yes

Event Timeline

Apologies for the lack of a tag but for the love of me I can't figure out who/what tag goes with the bog standard ui of MediaWiki.

@Lokal_Profil You can always use the generic MediaWiki-General...

Thanks. In general findability of tags is an issue in phabricator and I often feel that the auto-complete functionally fails to suggest the relevant tag.

That said I did find a tag after finding a gerrit patch through the release change logs so there is a way I guess :)

matmarex added a subscriber: matmarex.

This works for me locally, and the code definitely looks like it's meant to work that way (SkinTemplate::buildNavUrls()). I wonder if this is yet another problem caused by T132629?

This works for me locally, and the code definitely looks like it's meant to work that way (SkinTemplate::buildNavUrls()). I wonder if this is yet another problem caused by T132629?

Possibly. Several of the other toolbox links however deals with oldid correctly.

Krinkle edited projects, added MediaWiki-Interface; removed WMF-General-or-Unknown.

declined, as feature now deprecated and to be removed.