Page MenuHomePhabricator

Create a class to make EventRelayer to send events to EventBus endpoint
Closed, ResolvedPublic

Description

Create a class for sending EventRelayer events to EventBus endpoint.

Details

Related Gerrit Patches:
mediawiki/extensions/EventBus : masterAdd EventRelayer adapter
mediawiki/core : masterConvert CdnCacheUpdate to event per URL

Event Timeline

Restricted Application added a subscriber: Zppix. · View Herald TranscriptMay 5 2016, 11:31 PM

Change 288319 had a related patch set uploaded (by Smalyshev):
Add EventRelayer adapter

https://gerrit.wikimedia.org/r/288319

Change 289010 had a related patch set uploaded (by Smalyshev):
Converd CdnCacheUpdate to event per URL

https://gerrit.wikimedia.org/r/289010

Change 289010 merged by jenkins-bot:
Convert CdnCacheUpdate to event per URL

https://gerrit.wikimedia.org/r/289010

Change 288319 merged by jenkins-bot:
Add EventRelayer adapter

https://gerrit.wikimedia.org/r/288319

Smalyshev closed this task as Resolved.May 25 2016, 10:06 PM

@Smalyshev Is that live? We don't see any significant increase in the rate of resource-change events. (https://grafana.wikimedia.org/dashboard/db/eventbus).

Also, I'm too late for the reviewing party, but wanted to ask - is that possible to add some tag to the event? resource_change events support adding an array of tags, which we actively use for matching. Since your events would need their own rules, not mixed with other rules, it could be useful to add an eventrelayer or memcached tag to the events.

@Smalyshev Is that live? We don't see any significant increase in the rate of resource-change events. (https://grafana.wikimedia.org/dashboard/db/eventbus).

This is not in prod yet as it was merged 2 days ago. It'll go out with 1.28.0-wmf.4 (next week).

Also, I'm too late for the reviewing party, but wanted to ask - is that possible to add some tag to the event? resource_change events support adding an array of tags, which we actively use for matching. Since your events would need their own rules, not mixed with other rules, it could be useful to add an eventrelayer or memcached tag to the events.

+1 to that. I wanted to review the patch but you guys merged it right after the meeting :/ Anyhow, both event types will have to be tagged, so that we know it is safe to issue pruge requests for those. Moreover, the memcached type will likely need a different type of purging than CDN ones.

The class has been merged, but actually deploying it needs configuration changes. Which means we need to a) decide which channel it goes to b) configure mediawiki to actually send the events to that channel (tag can be added too, I think) and c) process the events. As soon as we're done with Memorial Day holidays, I plan to look into it.

@mobrovac If you have any comments on the patch, you are welcome to make them now. Since the patch is not actually enabled yet, it is not too late to change things if needed.