Maniphest T134772

Update NavigationTiming to reflect when lazy loaded images in force
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

As a data analyst, I want NavigationTiming event logging to reflect when by MediaWiki server configuration lazy loaded images are in force.

Presently, NavigationTiming code looks for a cookie (related code: Navigation Timing extension, Varnish VCL for cache split), but when the configuration is not cookie driven (i.e., when the markup and JavaScript are on by default) I want to ensure that events in the event logging table are reflective of as much.

Update cookie to use mw.config (no changes in schema needed)

Details

	Subject	Repo	Branch	Lines +/-
	Use config variable rather than cookie	mediawiki/extensions/NavigationTiming	wmf/1.27.0-wmf.23	+3 -4
	Use config variable rather than cookie	mediawiki/extensions/NavigationTiming	master	+3 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
		Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
		Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
		Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
		Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
		Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
		Resolved		dr0ptp4kt	T114542 Next Generation Content Loading and Routing, in Practice
		Duplicate		• Jhernandez	T104432 [EPIC]: Improve mobile site performance
		Duplicate		dr0ptp4kt	T120341 [GOAL] Make Wikipedia more accessible to all connections with new fast API-driven web experience in mobile web beta
		Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
		Resolved		Jdlrobson	T113066 [GOAL] Make Wikipedia more accessible to 2G connections
		Resolved		Jdlrobson	T124390 [GOAL] Load images with care
		Resolved		Jdlrobson	T134003 Deploy lazy loaded images to a few more wikis
		Resolved		Jdlrobson	T134772 Update NavigationTiming to reflect when lazy loaded images in force

Event Timeline

dr0ptp4kt created this task.May 9 2016, 3:22 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 9 2016, 3:22 PM

dr0ptp4kt added a project: Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.May 9 2016, 3:22 PM

dr0ptp4kt added a parent task: T134003: Deploy lazy loaded images to a few more wikis.

Krenair added a project: NavigationTiming.May 9 2016, 3:59 PM

Jdlrobson updated the task description. (Show Details)May 9 2016, 4:35 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 9 2016, 4:38 PM

Jdlrobson set the point value for this task to 0.5.

Jdlrobson claimed this task.May 9 2016, 5:57 PM

Jdlrobson moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.

Change 287671 had a related patch set uploaded (by Jdlrobson):
Use config variable rather than cookie

https://gerrit.wikimedia.org/r/287671

gerritbot added a project: Patch-For-Review.May 9 2016, 6:05 PM

Jdlrobson moved this task from Blocked Externally to -1 (Needs More Work) on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 9 2016, 6:05 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.

• Tbayer subscribed.May 9 2016, 9:33 PM

Change 287671 merged by jenkins-bot:
Use config variable rather than cookie

https://gerrit.wikimedia.org/r/287671

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)).May 10 2016, 3:00 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 10 2016, 4:12 PM

Change 288008 had a related patch set uploaded (by Jdlrobson):
Use config variable rather than cookie

https://gerrit.wikimedia.org/r/288008

Change 288008 abandoned by Jdlrobson:
Use config variable rather than cookie

Reason:
Ignore me

https://gerrit.wikimedia.org/r/288008

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.May 10 2016, 5:57 PM

Jdlrobson moved this task from Done to Ready for Signoff on the Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one board.

Jdlrobson removed a project: Patch-For-Review.

Over to you @dr0ptp4kt.

I'd like to check this in production which is stalled on this patch making it to Bengali Wikipedia (on 17th)

Do you mean the 19th?

This is working. I see entries where the flag is 'A' for Bengali wiki stable and when not Bengali wiki beta (since all betas are opted in)