| WMDE-Fisch | |
| May 11 2016, 1:49 PM |
| F4022577: revSliderDesign.png | |
| May 17 2016, 9:42 AM |
According to the current mock:
Colours of pointers as provided by @Jan_Dittrich:
Blue: fill #45a6ff, border #065cad
Yellow: fill #fdc44b, border #dda000
Also note that "pointer number 2" (blue one) should be moved above the x axis.
Also add a "shadow" dropped by the pointers to make it more distinct the pointers are interactive elements.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Tobi_WMDE_SW | T135116 [Task] Design rework/usability improvements | |||
| Resolved | WMDE-leszek | T134994 [Task] Adjust the pointer design |
Currently the left most pointer will always be the left side of the diff.
The colours of the pointers can swap over, but the above will maintain true.
I guess we want to stick with the yellowish and blue colour that are currently used by MediaWiki then.
And switch the colours when ever the pointers switch sides so that blue is always on the right?
Change 288584 had a related patch set uploaded (by Addshore):
Map pointer colors to diff colours
I've merged @Addshore's patch as I believe it does what is intended in this task.
If there is an intention to have some sort of link between a pointer and a column of a diff, then using some colours makes sense.
That said I found it quite confusing that I am moving my blue pointer left and out of sudden I am dragging a yellow one. Not knowing the code I wasn't sure what happened. Did pointers switch colours? Or maybe I am now dragging the other pointer than the one I started dragging?
For those reasons I'd opt for having pointers of the same colour. If there is a need to making it even more obvious that left pointer stands for the left diff column and right pointer for the right column, I'd suggest some other means than using the colour.
Or maybe have two colours but not allow "right" pointer to go further left then one revision after the "left" pointer, and the other way round. But that might also not be a perfect solution.
Oh, so there is already a patch for stopping having distinct left and right pointer https://gerrit.wikimedia.org/r/#/c/288588/ :)
Yep, having left and right started confusing me in the case where they can be dragged anywhere, so thought best to kill that
This is my design for that function:
Blue slider: fill #45a6ff, border #065cad
Yellow slider: fill #fdc44b, border #dda000
Re-opened as the new mock has been provided. Updated the description of the task. Remaining bits here are:
Change 289190 had a related patch set uploaded (by WMDE-leszek):
Change the position of the "olid" pointer
Change 289420 had a related patch set uploaded (by WMDE-leszek):
[DNM] Add shadow around pointers