| • JKatzWMF | |
| May 11 2016, 8:48 PM |
| F3996555: Screen Shot 2016-05-11 at 11.56.42 AM.png | |
| May 11 2016, 8:48 PM |
| F3996556: Screen Shot 2016-05-11 at 11.56.16 AM.png | |
| May 11 2016, 8:48 PM |
Per T127250#2286335
Wikidata descriptions currently show up on Main pages and portal pages (basically any non-main namespace). This is not intentional and a distraction to users on those non-article pages.
AC
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T135433 Deploy Wikidata descriptions to all mobile web Wikipedias | |||
| Resolved | • jhobs | T135429 Deploy Wikidata descriptions to Catalan and Polish mobile web Wikipedias stable | |||
| Resolved | • jhobs | T138085 Ensure Wikidata descriptions disabled by default on stable channel prod cluster mobile web Wikipedias | |||
| Resolved | • jhobs | T127250 Prepare Wikidata descriptions to roll out to stable | |||
| Resolved | dr0ptp4kt | T135047 Prevent wikidata descriptions from showing on non-main namespace |
Change 291976 had a related patch set uploaded (by Jhobs):
Make Wikidata descriptions only show up on main namespace
Moving back to Code Review despite Jenkins failing because the failing test appears to be a timeout. Already sent for a recheck.
I'm not able to run the browser tests locally or against beta cluster from my machine. Something to do with the authentication and account creation steps:
browser (review/jhobs/wikidata $%) $ MEDIAWIKI_URL=http://en.wikipedia.beta.wmflabs.org/wiki/ MEDIAWIKI_API_URL=http://en.wikipedia.beta.wmflabs.org/w/api.php bundle exec cucumber features/wikidata_descriptions.feature
@chrome @firefox @en.m.wikipedia.beta.wmflabs.org @vagrant @extension-wikibase
Feature: Wikidata descriptions
Background: # features/wikidata_descriptions.feature:4
NeedCaptcha (MediawikiApi::CreateAccountError)
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_api-0.6.0/lib/mediawiki_api/client.rb:94:in `create_account_old'
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_api-0.6.0/lib/mediawiki_api/client.rb:92:in `create_account_old'
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_api-0.6.0/lib/mediawiki_api/client.rb:56:in `create_account'
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_selenium-1.7.1/lib/mediawiki_selenium/user_factory.rb:38:in `create_account'
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_selenium-1.7.1/lib/mediawiki_selenium/user_factory.rb:30:in `create'
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_selenium-1.7.1/lib/mediawiki_selenium/helpers/user_factory_helper.rb:34:in `block (2 levels) in <module:UserFactoryHelper>'
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_selenium-1.7.1/lib/mediawiki_selenium/helpers/api_helper.rb:17:in `api'
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_selenium-1.7.1/lib/mediawiki_selenium/helpers/api_helper.rb:39:in `missing_extensions'
/Users/jhernandez/.rvm/gems/ruby-2.1.1/gems/mediawiki_selenium-1.7.1/lib/mediawiki_selenium/cucumber/hooks.rb:49:in `Before'
Given I am using the mobile site # features/step_definitions/common_steps.rb:54
{"errorMessage":"Unable to set Cookie","request":{"headers":{"Accept":"application/json","Accept-Encoding":"gzip;q=1.0,deflate;q=0.6,identity;q=0.3","Connection":"close","Content-Length":"116","Content-Type":"application/json; charset=utf-8","Host":"127.0.0.1:8910","User-Agent":"Ruby"},"httpVersion":"1.1","method":"POST","post":"{\"cookie\":{\"name\":\"mf_useformat\",\"value\":\"true\",\"secure\":false,\"path\":\"/\",\"domain\":\"en.wikipedia.beta.wmflabs.org\"}}","url":"/cookie","urlParsed":{"anchor":"","query":"","file":"cookie","directory":"/","path":"/cookie","relative":"/cookie","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/cookie","queryKey":{},"chunks":["cookie"]},"urlOriginal":"/session/76417d20-27eb-11e6-86ab-a315a6ce0be5/cookie"}} (org.openqa.selenium.UnableToSetCookieException) (Selenium::WebDriver::Error::UnableToSetCookieError)
./features/step_definitions/common_steps.rb:59:in `block (2 levels) in <top (required)>'
./features/step_definitions/common_steps.rb:55:in `/^I am using the mobile site$/'
features/wikidata_descriptions.feature:5:in `Given I am using the mobile site'
And I am on the "Main Page" page # features/step_definitions/common_steps.rb:48
Scenario: Description does not appear on Main Page # features/wikidata_descriptions.feature:8
Then I should not see a wikidata description # features/step_definitions/wikidata_descriptions.rb:5
Scenario: Description appears on main namespace # features/wikidata_descriptions.feature:11
When I am on the "Albert Einstein" page # features/step_definitions/common_steps.rb:48
Then I should see a wikidata description # features/step_definitions/wikidata_descriptions.rb:1
Scenario: Description does not appear on non-main namespaces # features/wikidata_descriptions.feature:15
Given I am on the "Talk:Contributions" page # features/step_definitions/common_steps.rb:48
Then I should not see a wikidata description # features/step_definitions/wikidata_descriptions.rb:5
Scenario: Description does not appear on special pages # features/wikidata_descriptions.feature:19
Given I am on the "Special:Contributions" page # features/step_definitions/common_steps.rb:48
Then I should not see a wikidata description # features/step_definitions/wikidata_descriptions.rb:5
Failing Scenarios:
cucumber features/wikidata_descriptions.feature:8 # Scenario: Description does not appear on Main Page
4 scenarios (1 failed, 3 skipped)
15 steps (1 failed, 14 skipped)
0m8.090sNot sure if it's just my setup.
Locally I'm not able to successfully install the wikidata role, so running the tests complains about the missing wikibase extension obviously.
Here's my log locally when provisioning after enabling the role, seems like there is a mismatch between elastic 1.7 and 2 somewhere. I'm getting very tired of this. I'm about to blow up my mediawiki-vagrant installation...
Judging by the error message the bug T129472 may still be alive. @zeljkofilipin can you help us out here?
@jhobs please fold the changes into https://gerrit.wikimedia.org/r/292190 into your patch and I can confirm this is then ready to go.
I've triggered a new job - https://integration.wikimedia.org/ci/view/Mobile/job/selenium-MobileFrontend/
Seems the tests are skipped :(
https://integration.wikimedia.org/ci/view/Mobile/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/lastCompletedBuild/testReport/(root)/Wikidata%20descriptions/
It looks like we need to remove @ext-wikibase - that doesn't appear to be working as expected (cc @zeljkofilipin )
I've submitted a small follow-on hygiene change for @jhobs' review: 292371: Don't check namespace twice
Ping @JKatzWMF. The description from Q2268 isn't visible on http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page?mobileaction=beta.