Page MenuHomePhabricator
Create Task
Maniphest T135525

Cannot log out on beta
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. go to http://en.wikipedia.beta.wmflabs.org/
  2. register new account
  3. log out

CentralAuth will immediately log you back in.

Could not reproduce with a non-new account.

Details

SubjectRepoBranchLines +/-
Fix central logoutmediawiki/extensions/CentralAuthREL1_27+3 -2
Fix central logoutmediawiki/extensions/CentralAuthmaster+3 -2
Fix central logoutmediawiki/extensions/CentralAuthwmf/1.28.0-wmf.2+3 -2
Revert "Avoid DBPerformance log warnings in onUserLogout()"mediawiki/extensions/CentralAuthmaster+5 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• mmodellT134450 MW-1.28.0-wmf.2 deployment blockers
 ResolvedAnomieT135525 Cannot log out on beta

Event Timeline

Tgr created this task.May 17 2016, 4:52 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 17 2016, 4:52 PM
Tgr triaged this task as Unbreak Now! priority.May 17 2016, 4:52 PM
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 17 2016, 4:52 PM
Tgr added a parent task: T134450: MW-1.28.0-wmf.2 deployment blockers.May 17 2016, 4:52 PM
Tgr added a comment.May 17 2016, 5:02 PM

Patches that might be relevant:

Anomie subscribed.May 17 2016, 5:18 PM
In T135525#2301748, @Tgr wrote:

Seems very unlikely, since it shouldn't be coming into play at all here. CentralAuth only sets the flag in CentralAuthTokenSessionProvider, which isn't being used here.

gerritbot subscribed.May 17 2016, 5:42 PM

Change 289246 had a related patch set uploaded (by Gergő Tisza):
Revert "Avoid DBPerformance log warnings in onUserLogout()"

https://gerrit.wikimedia.org/r/289246

gerritbot added a project: Patch-For-Review.May 17 2016, 5:42 PM
gerritbot added a comment.May 17 2016, 5:49 PM

Change 289246 abandoned by Gergő Tisza:
Revert "Avoid DBPerformance log warnings in onUserLogout()"

Reason:
anomie found a fix.

https://gerrit.wikimedia.org/r/289246

gerritbot added a comment.May 17 2016, 5:50 PM

Change 289248 had a related patch set uploaded (by Gergő Tisza):
Fix central logout

https://gerrit.wikimedia.org/r/289248

gerritbot added a comment.May 17 2016, 5:54 PM

Change 289248 merged by jenkins-bot:
Fix central logout

https://gerrit.wikimedia.org/r/289248

Anomie closed this task as Resolved.May 17 2016, 6:46 PM
Anomie claimed this task.
Luke081515 mentioned this in T135639: Can't logout @test2wiki, centralauth logs you back in.May 18 2016, 3:32 PM
gerritbot added a comment.May 18 2016, 3:36 PM

Change 289431 had a related patch set uploaded (by Gergő Tisza):
Fix central logout

https://gerrit.wikimedia.org/r/289431

gerritbot added a comment.May 18 2016, 3:39 PM

Change 289431 merged by Thcipriani:
Fix central logout

https://gerrit.wikimedia.org/r/289431

gerritbot added a comment.Jul 19 2016, 10:16 PM

Change 299880 had a related patch set uploaded (by Gergő Tisza):
Fix central logout

https://gerrit.wikimedia.org/r/299880

gerritbot added a comment.Jul 19 2016, 11:10 PM

Change 299880 merged by jenkins-bot:
Fix central logout

https://gerrit.wikimedia.org/r/299880

MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.Dec 15 2016, 4:16 PM
Restricted Application added a subscriber: Jay8g. · View Herald TranscriptDec 15 2016, 4:16 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits