Visit https://en.m.wikipedia.org/wiki/Timeline_of_the_presidency_of_Barack_Obama_(2010)?mobileaction=beta on desktop browser and you'll see the following:
Notice the watchstar icon overlaps the title.
Description
Description
Details
Details
Event Timeline
Comment Actions
@MBinder_WMF Do we tag bugs and regressions pulled into the sprint as unplanned sprint work or only unplanned tasks?
Comment Actions
@Jhernandez To keep it simple, we tag anything that enters the sprint after the sprint starts. In response to your question, I think there could be a case made for not tagging tasks that are, say, bugs that are part of an already-planned task. That would be like the estimation conversation we had on email regarding estimating bugs. I don't think this team tends to track that type of work though; it usually just uses the existing ticket.
Comment Actions
The task description is misleading. I think this is due to the heading not having correct width not due to the watchstar being in the wrong place.
Comment Actions
Change 289701 had a related patch set uploaded (by Jdlrobson):
Add a gutter for header to avoid page action overlap
Comment Actions
Technically, the change LGTM. However, with an extraordinarily long title, it would result in the following layout on, for example, an iPad:
/cc @Nirzar
Comment Actions
Can you take the screenshot again with the box model highlights? It looks to me like 'really' would overlap the watchstar if it was on the same line so I'm not sure what you would expect it to do in this situation instead.
Comment Actions
After some analysis I really don't think this is worth any more effort without sitting down and discussing and estimating. We may want to revisit this before we ship the new language switcher.
Comment Actions
@Jdlrobson @dr0ptp4kt This is in Code Review, so presumably work has been done on it. Can we split off the remaining work into a followup task? I think that would be better than stopping completely at this point.
Comment Actions
Change 290901 had a related patch set uploaded (by Phuedx):
[WIP] Wrap heading around actions at tablet widths
Comment Actions
With 290901: WIP Wrap heading around actions at tablet widths checked out, I see the following:
/cc @Nirzar
Comment Actions
@mbinder, are you suggesting we close this task and then create a separate task to capture whatever it is that we now better understand we're trying to achieve? I'm fine with that. @Jdlrobson okay? You able to spec the criteria in a task and, assuming it's related to lang switching, make it a blocking subtask of that?
Comment Actions
I've reviewed @phuedx patch and I think it is a good solution that works great.
I don't think there's a need to subtask it and all that, keep it in code review until the current patch and the followup have been reviewed and merged or abandoned.
There's time in the sprint to resolve this.
Comment Actions
I've merged both, moving to signoff.
If there are any concerns we can revert or followup before Tuesday.
Comment Actions
Change 289701 merged by jenkins-bot:
Add a gutter for header to avoid page action overlap