Page MenuHomePhabricator
Create Task
Maniphest T135758

Hovercards transpose lang and dir
Closed, ResolvedPublic
Actions

Description

(Recent report from hewiki user):

recently, hovercards text on hewiki is displayed left-aligned.
inspecting the HTML, i see:

<a dir="he" lang="rtl" class="mwe-popups-extract" href="/wiki/%D7%AA%D7%9C%D7%9E%D7%95%D7%93">

instead of the expected

lang="he" dir="rtl"

peace.

Details

SubjectRepoBranchLines +/-
Unswap langcode and langdir variables in popup.mustachemediawiki/extensions/Popupsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Kipod created this task.May 19 2016, 6:07 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 19 2016, 6:07 PM
Ricordisamoa claimed this task.May 20 2016, 4:56 AM
Ricordisamoa edited projects, added I18n, good first task; removed MediaWiki-extensions-Interlanguage.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 20 2016, 4:56 AM
gerritbot subscribed.May 20 2016, 5:00 AM

Change 289814 had a related patch set uploaded (by Ricordisamoa):
Unswap langcode and langdir variables in popup.mustache

https://gerrit.wikimedia.org/r/289814

gerritbot added a project: Patch-For-Review.May 20 2016, 5:00 AM
Ricordisamoa mentioned this in T127282: Phabricator does not list project addition anymore on task creation (in the UI and mail notifications).May 20 2016, 6:56 AM
Jdlrobson added projects: Unplanned-Sprint-Work, Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card.May 20 2016, 3:36 PM
Jdlrobson subscribed.

Do we want to SWAT fix this Monday?

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card board.May 20 2016, 3:37 PM
gerritbot added a comment.May 20 2016, 3:47 PM

Change 289814 merged by jenkins-bot:
Unswap langcode and langdir variables in popup.mustache

https://gerrit.wikimedia.org/r/289814

Jdlrobson removed a project: Patch-For-Review.May 20 2016, 4:02 PM
• jhobs renamed this task from hovercards transopse lang and dir to Hovercards transpose lang and dir.May 23 2016, 4:21 PM
• jhobs triaged this task as Medium priority.May 23 2016, 6:11 PM
• jhobs added a project: Web-Team-Backlog.
dr0ptp4kt moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.May 23 2016, 7:47 PM
Jdlrobson added a comment.May 23 2016, 10:30 PM

If I have to SWAT another fix tomorrow I'll do this, otherwise we'll let it ride the train.

• Jhernandez closed this task as Resolved.May 24 2016, 10:24 AM
• Jhernandez subscribed.

Confirmed fix in http://reading-web-staging.wmflabs.org/wiki/Main_Page

Will either swat today or ride train and be available tomorrow/thursday.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)).May 31 2016, 6:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL