Page MenuHomePhabricator

Add blacklist support to scap.tasks.check_valid_syntax linter
Closed, ResolvedPublic

Description

Allow blacklisting of files/directories known to fail PHP lint checks so that scap sync-dir, scap sync-file and scap sync can work with branches containing vendor directories created with Composer 1.1.x.

See T135161: Composer v1.1.0 generated vendor dirs will fail lint by PHP <5.6 for more details.

Revisions and Commits

Event Timeline

I found a way to move forward using a script.

It is safe and wont cause harm.

Change 320098 had a related patch set uploaded (by Paladox):
Add a script so we can disable loading the new autoload_static file

https://gerrit.wikimedia.org/r/320098

Change 320098 abandoned by Paladox:
Add a script so we can disable loading the new autoload_static file

Reason:
Yes but some of our linters doint support it expecially php -l.

https://gerrit.wikimedia.org/r/320098

That at least fixes the offending file... Or do we need/want to add a more extensible blacklist version?

@Reedy Oh I think your fix will do for now, but what I'm thinking about is how can it tell where the vendor folder is or where to find that autoload file.

Paladox added a revision: Restricted Differential Revision.Nov 9 2016, 8:39 PM
Legoktm assigned this task to Paladox.