Page MenuHomePhabricator
Create Task
Maniphest T136408

Update CentralNotice JSHint config to restrict syntax to ES3 (disallow ES5 or ES6)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

As came out from a global crash, when regular browsers of many users refused to operate on wiki pages (details at T136387), the automatic patch inspection should be improved.

ECMA level should be checked.

If you put the rECNO /resources/subscribing/ext.centralNotice.display.state.js code as of rECNO1169f1d27aca132cea636aa970620d5ad70712ee into http://jshint.com/ it will tell you

Line 361 'concise methods' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

Such warnings should block proliferation, and reviewers must not ignore them.

Details

SubjectRepoBranchLines +/-
Update extensions/CentralNotice submodulemediawiki/corewmf/1.28.0-wmf.4+1 -1
Re-apply "jshint, gruntfile, and compatibility fixes" (part 1)mediawiki/extensions/CentralNoticewmf_deploy+8 -6
Re-apply "jshint, gruntfile, and compatibility fixes" (part 2)mediawiki/extensions/CentralNoticemaster+16 -10
Re-apply "jshint, gruntfile, and compatibility fixes" (part 1)mediawiki/extensions/CentralNoticemaster+8 -6
Revert "jshint, gruntfile, and compatibility fixes"mediawiki/extensions/CentralNoticemaster+16 -24
jshint, gruntfile, and compatibility fixes (partial, wmf_deploy branch only)mediawiki/extensions/CentralNoticewmf_deploy+17 -9
jshint, gruntfile, and compatibility fixesmediawiki/extensions/CentralNoticemaster+24 -16
Customize query in gerrit

Related Objects

Event Timeline

PerfektesChaos created this task.May 27 2016, 1:24 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 27 2016, 1:24 PM
matmarex added a project: MediaWiki-extensions-CentralNotice.May 27 2016, 1:27 PM
matmarex mentioned this in T136387: CentralNotice failing in older browsers due use of ECMAScript 6 syntax.May 27 2016, 4:07 PM
matmarex added a project: Fundraising-Backlog.
matmarex subscribed.
Krinkle renamed this task from Introduce automatic ECMA version check on JS patch review to Update CentralNotice JSHint config to restrict syntax to ES3 (disallow ES5 or ES6).May 27 2016, 4:08 PM
gerritbot subscribed.May 27 2016, 4:43 PM

Change 291264 had a related patch set uploaded (by Ejegg):
WIP jshint and gruntfile fixes

https://gerrit.wikimedia.org/r/291264

gerritbot added a project: Patch-For-Review.May 27 2016, 4:43 PM
gerritbot added a comment.May 27 2016, 7:28 PM

Change 291264 merged by jenkins-bot:
jshint, gruntfile, and compatibility fixes

https://gerrit.wikimedia.org/r/291264

matmarex closed this task as Resolved.May 27 2016, 7:31 PM
matmarex assigned this task to Ejegg.
matmarex removed a project: Patch-For-Review.
Ejegg added projects: Unplanned-Sprint-Work, Fundraising Sprint Killing Time.May 27 2016, 7:33 PM
Ejegg set the point value for this task to 1.
Ejegg moved this task from Backlog to Done on the Fundraising Sprint Killing Time board.
PerfektesChaos mentioned this in T136457: Ensure that all repos have sufficient .jshintrc spec.May 27 2016, 10:42 PM
AndyRussG subscribed.May 28 2016, 2:07 AM

Thx!!!!

• DStrine moved this task from Triage to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.Jun 1 2016, 6:56 PM
gerritbot added a comment.Jun 2 2016, 2:58 PM

Change 292368 had a related patch set uploaded (by AndyRussG):
jshint, gruntfile, and compatibility fixes (partial, wmf_deploy branch only)

https://gerrit.wikimedia.org/r/292368

gerritbot added a project: Patch-For-Review.Jun 2 2016, 2:58 PM
gerritbot added a comment.Jun 2 2016, 6:35 PM

Change 292401 had a related patch set uploaded (by AndyRussG):
Revert "jshint, gruntfile, and compatibility fixes"

https://gerrit.wikimedia.org/r/292401

gerritbot added a comment.Jun 2 2016, 6:35 PM

Change 292402 had a related patch set uploaded (by AndyRussG):
Re-apply "jshint, gruntfile, and compatibility fixes" (part 1)

https://gerrit.wikimedia.org/r/292402

gerritbot added a comment.Jun 2 2016, 6:35 PM

Change 292403 had a related patch set uploaded (by AndyRussG):
Re-apply "jshint, gruntfile, and compatibility fixes" (part 2)

https://gerrit.wikimedia.org/r/292403

gerritbot added a comment.Jun 2 2016, 6:37 PM

Change 292404 had a related patch set uploaded (by AndyRussG):
Re-apply "jshint, gruntfile, and compatibility fixes" (part 1)

https://gerrit.wikimedia.org/r/292404

gerritbot added a comment.Jun 2 2016, 7:31 PM

Change 292368 abandoned by AndyRussG:
jshint, gruntfile, and compatibility fixes (partial, wmf_deploy branch only)

Reason:
See instead I91de8b2dfa

https://gerrit.wikimedia.org/r/292368

gerritbot added a comment.Jun 2 2016, 10:41 PM

Change 292401 abandoned by AndyRussG:
Revert "jshint, gruntfile, and compatibility fixes"

Reason:
Unneeded, was part of planned administrative curiosities

https://gerrit.wikimedia.org/r/292401

gerritbot added a comment.Jun 2 2016, 10:42 PM

Change 292402 abandoned by AndyRussG:
Re-apply "jshint, gruntfile, and compatibility fixes" (part 1)

Reason:
Unneeded, was part of planned administrative curiosities

https://gerrit.wikimedia.org/r/292402

gerritbot added a comment.Jun 2 2016, 10:42 PM

Change 292403 abandoned by AndyRussG:
Re-apply "jshint, gruntfile, and compatibility fixes" (part 2)

Reason:
Unneeded, was part of planned administrative curiosities

https://gerrit.wikimedia.org/r/292403

gerritbot added a comment.Jun 2 2016, 11:00 PM

Change 292404 merged by jenkins-bot:
Re-apply "jshint, gruntfile, and compatibility fixes" (part 1)

https://gerrit.wikimedia.org/r/292404

gerritbot added a comment.Jun 2 2016, 11:34 PM

Change 292503 had a related patch set uploaded (by Awight):
Update extensions/CentralNotice submodule

https://gerrit.wikimedia.org/r/292503

Stashbot subscribed.Jun 2 2016, 11:59 PM

Mentioned in SAL [2016-06-02T23:59:36Z] <awight@tin> Started scap: Deploying labtestwiki AuthManager config; Enabling Popups experiment; CentralNotice fixes for T136408, T136387; Special:Notifications fixes

Stashbot added a comment.Jun 3 2016, 12:24 AM

Mentioned in SAL [2016-06-03T00:24:45Z] <awight@tin> Finished scap: Deploying labtestwiki AuthManager config; Enabling Popups experiment; CentralNotice fixes for T136408, T136387; Special:Notifications fixes (duration: 25m 08s)

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-31_(1.28.0-wmf.4)).Jun 8 2016, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits