Page MenuHomePhabricator
Create Task
Maniphest T136967

Israel and France 1hour tests processed in USD
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The one hour test completed on 6/3 did not use the correct currencies. Shekels and Euros were displayed to the users but we processed them in USD.

@Pcoombe used these links:

France
Ingenico - https://fr.wikipedia.org/wiki/?force=1&country=FR&banner=B1516_0602_frFR_dsk_p2_sm_pym_ingen
Adyen - https://fr.wikipedia.org/wiki/?force=1&country=FR&banner=B1516_0602_frFR_dsk_p2_sm_pym_adyen

Israel
https://he.wikipedia.org/wiki/?force=1&country=IL&banner=B1516_0602_heIL_dsk_p2_sm_pym_adyen

@MBeat33 confirmed all successful transactions were completed in USD

Event Timeline

• DStrine created this task.Jun 3 2016, 6:47 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 3 2016, 6:47 PM
nshahquinn-wmf renamed this task from Isreal and Franc 1hour tests processed in USD to Israel and France 1hour tests processed in USD.Jun 3 2016, 6:54 PM
• DStrine moved this task from Triage to Current Sprint & Completed in Q4 1516 on the Fundraising-Backlog board.Jun 3 2016, 6:56 PM
Pcoombe added a comment.Jun 3 2016, 8:56 PM

Is checking transactions are in the right currency something we could/should have unit tests for?

Ejegg subscribed.Jun 3 2016, 9:04 PM

For this one, we would have needed browser tests. We do have unit tests that simulate a currency code coming in on the request, and making sure it sends the right stuff to Adyen. The problem here was that the JavaScript was sending the wrong currency code in on the request. The php code was doing exactly what it was tested to do.

So... yeah, let's get some Selenium tests working on DI.

Ejegg claimed this task.Jun 3 2016, 9:05 PM
Ejegg triaged this task as Unbreak Now! priority.
Ejegg set the point value for this task to 1.
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptJun 3 2016, 9:05 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint Killing Time board.Jun 3 2016, 9:05 PM
Ejegg closed this task as Resolved.Jun 7 2016, 9:00 PM
• DStrine added a project: FR-Adyen.Aug 29 2016, 9:44 PM
Restricted Application added a subscriber: Jay8g. · View Herald TranscriptAug 29 2016, 9:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits