Page MenuHomePhabricator

Spike [2hrs] Wikidata description browser tests do not run anywhere
Closed, ResolvedPublic

Description

As pointed out in https://phabricator.wikimedia.org/T135047#2347448 but missed during sign off the browser tests for testing Wikidata descriptions do not run.

We use @ext-wikibase which appears to cause tests to skip when tests are run on the beta cluster despite this extension being installed there.

We should remove this tag and enforce it via other means (A "Is Wikidata installed" step) or work with the rel-eng team to work out why this happens.

Event Timeline

jhobs renamed this task from wikidata description browser tests do not run anywhere to Wikidata description browser tests do not run anywhere.Jun 15 2016, 3:19 PM
jhobs triaged this task as High priority.
jhobs moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson added a subscriber: Jhernandez.

Ping @Jhernandez we should either fix this or delete the test asap.

I'd rather have them fixed if they provide value.

I'm bringing it to 77 given we have room cc/ @dr0ptp4kt

MBinder_WMF renamed this task from Wikidata description browser tests do not run anywhere to Spike [2hrs] Wikidata description browser tests do not run anywhere.Jul 21 2016, 5:13 PM
MBinder_WMF updated the task description. (Show Details)
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.

I am happy to pair with somebody on this as soon as I am back from vacation.

@dr0ptp4kt @Jhernandez: Given that this is blocked – right? – on @zeljkofilipin being on vacation, should we bring another task into the sprint?

Makes sense. There's still work on preparing the language button for rollout though. I'll have a look.

@Jhernandez Is this in Needs Analysis because we're waiting to pair with @zeljkofilipin ? Given it was ready to work on, one could argue it's better placed in Blocked Externally.

Change 301421 had a related patch set uploaded (by Jdlrobson):
Drop @ext-wikibase tag from browser test

https://gerrit.wikimedia.org/r/301421

No pairing needed. The above patch is sufficient.

I've merged. @Jdlrobson can you help sign off and verify the test actually runs in beta cluster?

Change 301421 merged by jenkins-bot:
Drop @ext-wikibase tag from browser test

https://gerrit.wikimedia.org/r/301421