Page MenuHomePhabricator
Create Task
Maniphest T137868

World languages should appear in their correspondent regions too on the language selector
Closed, ResolvedPublic
Actions

Description

The language selector organises languages by region. There are some languages that belong to multiple regions and some of those are identified as Worldwide. Worldwide languages such as Spanish should also appear under their corresponding regions, but that does not seem to be the case currently.
This seems to be a regression since I recall this working as described before.

For example, when viewing a page available in many languages using compact language links, you can see that Spanish ("español") does not appear in Europe or America regions where it should appear in both of them.

Screen Shot 2016-06-15 at 09.28.38.png (393×892 px, 75 KB)

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Jun 15 2016, 7:29 AM
Amire80 moved this task from Backlog to Appearance and design on the ULS-CompactLinks board.Jul 7 2016, 8:47 AM
• santhosh subscribed.Jul 13 2016, 8:53 AM
Arrbee mentioned this in T136677: Deployment of Compact Language Links.Jul 18 2016, 1:33 PM
• santhosh added a comment.EditedJul 19 2016, 11:59 AM

We had intentionally avoided listing the world wide languages more than once. See https://github.com/wikimedia/jquery.uls/blob/master/src/jquery.uls.lcd.js#L97

T41921: Languages appear repeated for each region in search results despite being the only result - it said to avoid listing more than once while searching, but we are hiding it always if the language repeats

• santhosh added a comment.Jul 19 2016, 12:30 PM

I am inclined to undo the changes done for T41921: Languages appear repeated for each region in search results despite being the only result and avoid the unncessary complexity. Let the listing be consistant when searching or not and does not play hide and seek depending on number of search results.

Amire80 triaged this task as High priority.Jul 19 2016, 7:23 PM
Amire80 added projects: Language-Q1-2016-17 Sprint 2, Language-Engineering July-September 2016.
• santhosh added a comment.Jul 20 2016, 4:29 AM

PR: https://github.com/wikimedia/jquery.uls/pull/234

• santhosh claimed this task.Jul 20 2016, 4:43 AM
• santhosh moved this task from Backlog to In Progress on the Language-Q1-2016-17 Sprint 2 board.
Nikerabbit merged a task: T117196: Compact language links selector lists "Nederlands" only under "America", when not entering search term.Jul 27 2016, 7:33 AM
Nikerabbit added subscribers: Weft, liangent, Nemo_bis.
Amire80 moved this task from Backlog to ULS on the Language-Engineering July-September 2016 board.Jul 31 2016, 11:27 AM
• santhosh moved this task from In Progress to QA on the Language-Q1-2016-17 Sprint 2 board.Aug 2 2016, 6:02 AM
Arrbee subscribed.Aug 2 2016, 7:32 AM

https://gerrit.wikimedia.org/r/#/c/302222/

Amire80 closed this task as Resolved.Aug 9 2016, 8:04 PM
Amire80 subscribed.

Verified in production.

Amire80 moved this task from QA to Done on the Language-Q1-2016-17 Sprint 2 board.Aug 9 2016, 8:05 PM
Amire80 moved this task from Backlog to Appearance and design on the UniversalLanguageSelector board.Nov 1 2017, 3:08 PM
Amire80 mentioned this in T41921: Languages appear repeated for each region in search results despite being the only result.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL