Page MenuHomePhabricator
Create Task
Maniphest T138038

Clearer naming conventions for Non-JS CSS files like `mediawiki.action.history.styles.css`
Closed, DuplicatePublic
Actions

Description

Currently we implement modules with two CSS/Less files named

  • mediawiki.action.history.css
  • mediawiki.action.history.styles.css

One for styling elements in the main rendering, and the other for elements specific to the JS enhanced experience.

Let's find a less confusing and redundant naming pattern.
Are all the occasions of *.styles.css only including “basic” styles for non-JS support like the above as this task is a follow-up to https://gerrit.wikimedia.org/r/#/c/294701
Others in core are:

  • mediawiki.action.edit.styles.css
  • mediawiki.special.preferences.styles.css
  • mediawiki.special.search.styles.css
  • mediawiki.special.upload.styles.css

Related Objects

Event Timeline

Volker_E created this task.Jun 16 2016, 10:37 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 16 2016, 10:37 PM
Krinkle updated the task description. (Show Details)Jun 16 2016, 11:40 PM
Danny_B edited projects, added Front-end-Standards-Group; removed MediaWiki-General.Jul 2 2016, 10:55 PM
Volker_E added a comment.Jul 13 2016, 4:56 PM

Echo uses in its [[ https://phabricator.wikimedia.org/diffusion/ECHO/browse/wmf%252F1.28.0-wmf.9/modules/ | modules folder two sub-folders ]] – nojs and styles – side-by-side.
I like the idea of a nojs folder, but would rather like to see it as child of the corresponding folder like

  • mv resources/src/mediawiki.action/mediawiki.action.history.css resources/src/mediawiki.action/nojs/mediawiki.action.history.css

Can ResourceLoader handle two files with the same name in two folders?

Volker_E triaged this task as Low priority.Jul 13 2016, 4:56 PM
Volker_E moved this task from Inbox to Accepted on the Front-end-Standards-Group board.
Volker_E moved this task from Accepted to Backlog on the Front-end-Standards-Group board.Jul 13 2016, 6:55 PM
Volker_E added a comment.EditedJul 15 2016, 1:58 PM

After a short conversation at the Front-end-Standards-Group meeting @Krinkle ensured, that RL would be able to handle two files like laid out above easily, but there has been a tendency lately (?), to change file names towards file paths reflecting module hierarchy.
The proposals that have been brought up:

  • resources/src/mediawiki.action/history.css
  • resources/src/mediawiki.action/nojs/history.css
  • resources/src/mediawiki.action/history/styles.css
  • resources/src/mediawiki.action/history/noscript.css
  • resources/src/mediawiki.action/history/basic.css or main.css
  • resources/src/mediawiki.action/history/dynamic.css or interactive.css
• Prtksxna subscribed.Jul 20 2016, 7:29 AM
Volker_E added a comment.Aug 6 2016, 1:18 PM

A related topic is naming of print-only styles as seen at https://gerrit.wikimedia.org/r/#/c/303353/ of T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature

Volker_E added a subscriber: Fomafix.Sep 6 2016, 8:51 PM

There has been a related patch on bringing more sanity to print-only CSS files https://gerrit.wikimedia.org/r/#/c/308193/ by @Fomafix

Aklapper removed Volker_E as the assignee of this task.Jun 19 2020, 4:28 PM

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

Krinkle closed this task as a duplicate of T193826: Organise module files in directories based on their module name.Jun 19 2020, 6:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits