Maniphest T138321

ULSCompactLinksEnableAnon config is not working
Closed, DeclinedPublic
Actions

Description

Compact Language Links was enabled by default despite of ULSCompactLinksEnableAnon was set 'false' at https://git.wikimedia.org/blob/operations%2Fmediawiki-config.git/master/wmf-config%2FInitialiseSettings.php#L12647

Details

	Subject	Repo	Branch	Lines +/-
	Fix ULSCompactLinksEnableAnon configuration	mediawiki/extensions/UniversalLanguageSelector	master	+2 -2

Customize query in gerrit

Event Timeline

KartikMistry created this task.Jun 21 2016, 4:37 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 21 2016, 4:37 PM

Change 295451 had a related patch set uploaded (by KartikMistry):
Fix ULSCompactLinksEnableAnon

https://gerrit.wikimedia.org/r/295451

gerritbot added a project: Patch-For-Review.Jun 22 2016, 3:56 AM

KartikMistry claimed this task.Jun 22 2016, 3:57 AM

KartikMistry triaged this task as Medium priority.

KartikMistry added projects: Language-Q4-2016-Sprint 5, Unplanned-Sprint-Work.

KartikMistry moved this task from Backlog to In Review on the Language-Q4-2016-Sprint 5 board.

Why would we ever disable compact links for logged out users but not logged in?

Change 295451 merged by jenkins-bot:
Fix ULSCompactLinksEnableAnon configuration

https://gerrit.wikimedia.org/r/295451

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)).Jun 22 2016, 10:00 AM

KartikMistry moved this task from In Review to QA on the Language-Q4-2016-Sprint 5 board.Jun 22 2016, 10:13 AM

Why would we ever disable compact links for logged out users but not logged in?

When we enable compact links for logged in users alone.

KartikMistry updated the task description. (Show Details)Jun 23 2016, 11:40 AM

Expected behavior is that $wgULSCompactLinksEnableAnon = false; does nothing.

KartikMistry moved this task from QA to Done on the Language-Q4-2016-Sprint 5 board.Jun 23 2016, 1:33 PM

Amire80 moved this task from Backlog to Compact Language Links on the UniversalLanguageSelector board.Nov 1 2017, 3:03 PM

Amire80 moved this task from Backlog to Other on the ULS-CompactLinks board.Nov 3 2017, 8:25 AM

Amire80 removed a project: Patch-For-Review.Nov 3 2017, 8:42 AM