Page MenuHomePhabricator
Create Task
Maniphest T138855

[Regression pre-wmf.8] Cite menu -> Citoid button doesn't happen when content language and user language differ or on uselang=XXX any more
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I presume the i18n-always-exist changes broke it looking for content language rather than user language?

[This is blocking a run of the new screenshots task.]

Details

SubjectRepoBranchLines +/-
Always load Citoid type map from data modulemediawiki/extensions/Citoidwmf/1.28.0-wmf.9+4 -11
Always load Citoid type map from data modulemediawiki/extensions/Citoidmaster+4 -11
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Jun 28 2016, 3:53 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 28 2016, 3:53 PM
Jdforrester-WMF added a subscriber: Esanders.Jun 28 2016, 3:53 PM
Danny_B added a project: Regression.Jul 1 2016, 9:00 PM
Jdforrester-WMF renamed this task from [Regression pre-wmf.8] Cite menu -> Citoid button doesn't happen on uselang=XXX any more to [Regression pre-wmf.8] Cite menu -> Citoid button doesn't happen when content language and user language differ or on uselang=XXX any more.Jul 2 2016, 9:43 AM
Jdforrester-WMF merged a task: T139223: Citoid broken for users whose interface language does not match content language.
Jdforrester-WMF added subscribers: • AlexMonk-WMF, gpaumier, jrbs.
gerritbot subscribed.Jul 7 2016, 4:05 PM

Change 297806 had a related patch set uploaded (by Esanders):
Always load Citoid type map from data module

https://gerrit.wikimedia.org/r/297806

gerritbot added a project: Patch-For-Review.Jul 7 2016, 4:05 PM
Esanders mentioned this in T139726: Citoid arbitrarily missing from certain Wikipedias for one user?.Jul 8 2016, 12:17 PM
• Elitre subscribed.Jul 8 2016, 12:18 PM
• Elitre added a subscriber: • Whatamidoing-WMF.Jul 8 2016, 5:36 PM
Jdforrester-WMF merged a task: T139726: Citoid arbitrarily missing from certain Wikipedias for one user?.Jul 11 2016, 6:26 PM
Jdforrester-WMF added a subscriber: Wittylama.
gerritbot added a comment.Jul 11 2016, 6:28 PM

Change 297806 merged by jenkins-bot:
Always load Citoid type map from data module

https://gerrit.wikimedia.org/r/297806

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Jul 11 2016, 7:00 PM
gerritbot added a comment.Jul 11 2016, 7:01 PM

Change 298327 had a related patch set uploaded (by Jforrester):
Always load Citoid type map from data module

https://gerrit.wikimedia.org/r/298327

gerritbot added a comment.Jul 11 2016, 11:26 PM

Change 298327 merged by jenkins-bot:
Always load Citoid type map from data module

https://gerrit.wikimedia.org/r/298327

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jul 12 2016, 12:00 AM
Jdforrester-WMF closed this task as Resolved.Jul 12 2016, 12:03 AM
Jdforrester-WMF assigned this task to Esanders.

Now fixed in production. Sorry, all!

Wittylama added a comment.Jul 13 2016, 9:26 AM

I've just tested the new change with the person who reported the problem to me in the first place. When logged in (even after logging out and back in again) the problem persisted on English and Catalan Wikipedias (not any other language WP).

However, then I got this person to look at their language preferences - and they were set to en-GB. When I changed it to simply "en", then the citation system works correctly now.

So, for this person, the problem is solved by changing their profile to "en" from "en-gb". But there's something still odd with the system that refuses to show the citation tool when set to that language.

Jdforrester-WMF reopened this task as Open.Jul 22 2016, 7:10 PM
In T138855#2457040, @Wittylama wrote:

I've just tested the new change with the person who reported the problem to me in the first place. When logged in (even after logging out and back in again) the problem persisted on English and Catalan Wikipedias (not any other language WP).

However, then I got this person to look at their language preferences - and they were set to en-GB. When I changed it to simply "en", then the citation system works correctly now.

So, for this person, the problem is solved by changing their profile to "en" from "en-gb". But there's something still odd with the system that refuses to show the citation tool when set to that language.

Sorry, the fix might have taken a little while to apply; changing language to 'en-gb' is not necessary. I've just tested this again in production in en, en-gb, and fr, and it works in all of them.

Jdforrester-WMF closed this task as Resolved.Jul 22 2016, 7:10 PM

Bah.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL