There should be a visual indication that setting a table's properties to 'sortable' worked
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	• Whatamidoing-WMF
	Jun 30 2016, 4:04 PM

Description

Current situation:

Edit a table. Click 'Properties' and set it to 'sortable'. See no change on the table. Wonder whether it worked. Check the properties tab again. Yes, it's set. Wonder what's going on.

Desired result:

Edit a table. Click 'Properties' and set it to 'sortable'. See something change on the page (add the correct set of arrows to the top row? Pop up an annoying little message to say that it worked?). Be confident that it worked.

Details

	Subject	Repo	Branch	Lines +/-
	Provide approximate preview of table sort styling	mediawiki/extensions/VisualEditor	master	+28 -4
	ve.ce.MWTableNode: Provide preview of sortable table styling	mediawiki/extensions/VisualEditor	master	+110 -0

Customize query in gerrit

Related Objects

Mentioned In: T194323: [Regression wmf.3] Selecting "Collapsed initially" makes the table look broken with an unclickable useless text [Expand]
T154649: wikitable sortable in visual editor
T153293: Provide preview in visual mode so I can interact with the content (e.g. test out table sortability) without saving
Mentioned Here: T95189: Support sortable columns in tables

Event Timeline

• Whatamidoing-WMF created this task.Jun 30 2016, 4:04 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 30 2016, 4:04 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald Transcript

This was done for T95189: Support sortable columns in tables but not merged due to complaints from @matmarex about the icons (I think?). It'd be nice to get completed.

Change 269153 had a related patch set uploaded (by Esanders):
Provide approximate preview of table sort styling

https://gerrit.wikimedia.org/r/269153

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jul 26 2016, 7:20 PM

There is still my attempt at F3325021 which I imagine still possibly works.

Jdforrester-WMF added a project: Design.Aug 12 2016, 8:24 PM

Jdforrester-WMF set the point value for this task to 8.

matmarex claimed this task.Dec 16 2016, 8:01 PM

Jdforrester-WMF mentioned this in T153293: Provide preview in visual mode so I can interact with the content (e.g. test out table sortability) without saving.Jan 3 2017, 9:48 PM

Stryn subscribed.Jan 11 2017, 6:14 PM

Stryn mentioned this in T154649: wikitable sortable in visual editor.Jan 11 2017, 6:18 PM

Pearli123 subscribed.Jan 12 2017, 6:40 PM

Good example for some corner cases:

{| class="wikitable sortable"
! rowspan="2" |1
! colspan="2" |2
! colspan="2" rowspan="2" |3
|-
!4
!5
|-
| 16 || 18 || 23 || 13 || 25
|-
| 17 || 10 || 22 || 21 || 14
|-
| 24 || 11 || 19 || 20 || 12
|}

Change 332743 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ce.MWTableNode: Provide preview of sortable table styling

https://gerrit.wikimedia.org/r/332743

gerritbot added a project: Patch-For-Review.Jan 18 2017, 8:31 AM

• Elitre merged a task: T154649: wikitable sortable in visual editor.Jan 19 2017, 6:06 PM

• Elitre added a subscriber: Ryasmeen.

• Elitre subscribed.

Change 332743 merged by jenkins-bot:
ve.ce.MWTableNode: Provide preview of sortable table styling

https://gerrit.wikimedia.org/r/332743

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)).Feb 13 2017, 11:00 PM

Jdforrester-WMF closed this task as Resolved.Feb 13 2017, 11:08 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 13 2017, 11:08 PM

Ryasmeen added projects: Verified, Verified-in-Phase0.Feb 15 2017, 8:21 PM

Ryasmeen added a project: Verified-in-Phase2.Feb 16 2017, 9:53 PM

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.

Change 269153 abandoned by Esanders:
Provide approximate preview of table sort styling

Reason:
https://gerrit.wikimedia.org/r/332743