Page MenuHomePhabricator
Create Task
Maniphest T95189

Support sortable columns in tables
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

It should be possible to make columns in tables be sortable.

Details

SubjectRepoBranchLines +/-
TableSorter: Avoid FOUC and preserve styling in VisualEditormediawiki/coremaster+22 -4
Add controls for wikitable and sortable to table dialogmediawiki/extensions/VisualEditormaster+99 -0
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Apr 6 2015, 5:17 PM
• Whatamidoing-WMF raised the priority of this task from to Needs Triage.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added projects: VisualEditor, VisualEditor-Tables.
• Whatamidoing-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2015, 5:17 PM
Aklapper merged a task: T96483: Be able to sort table columns.Apr 18 2015, 7:13 PM
Aklapper mentioned this in T96483: Be able to sort table columns.
Aklapper added a subscriber: Stryn.
Jdforrester-WMF triaged this task as Medium priority.Apr 21 2015, 5:46 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.May 8 2015, 1:44 AM
• Elitre subscribed.Nov 2 2015, 4:17 PM
Jdforrester-WMF merged a task: T121267: Be able to set a table to class= "sortable".Dec 15 2015, 8:14 PM
Jdforrester-WMF added a subscriber: StudiesWorld.
gerritbot subscribed.Jan 25 2016, 5:17 PM

Change 266260 had a related patch set uploaded (by Esanders):
TableSorter: Preserve styling in VisualEditor

https://gerrit.wikimedia.org/r/266260

gerritbot added a project: Patch-For-Review.Jan 25 2016, 5:17 PM
gerritbot added a comment.Jan 26 2016, 1:23 PM

Change 266260 merged by jenkins-bot:
TableSorter: Avoid FOUC and preserve styling in VisualEditor

https://gerrit.wikimedia.org/r/266260

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 26 2016, 2:00 PM
Jdforrester-WMF removed projects: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes, Patch-For-Review.Jan 26 2016, 10:15 PM
Jdforrester-WMF edited a custom field.
• Esanders added a subtask: T99890: Make it possible to edit a table cell's data-sort-value attribute, and data-sort-type for table header cells (for columns).Jan 29 2016, 6:46 PM
Jdforrester-WMF mentioned this in T99890: Make it possible to edit a table cell's data-sort-value attribute, and data-sort-type for table header cells (for columns).Jan 29 2016, 7:28 PM
gerritbot added a comment.Jan 31 2016, 2:47 PM

Change 267538 had a related patch set uploaded (by Esanders):
Add controls for wikitable and sortable to table dialog

https://gerrit.wikimedia.org/r/267538

gerritbot added a project: Patch-For-Review.Jan 31 2016, 2:47 PM
• Esanders moved this task from Backlog to User Interface on the VisualEditor-Tables board.Jan 31 2016, 3:00 PM
Jdforrester-WMF closed this task as Resolved.Feb 1 2016, 7:14 PM
Jdforrester-WMF assigned this task to • Esanders.
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)); removed Patch-For-Review.
Jdforrester-WMF removed a subtask: T99890: Make it possible to edit a table cell's data-sort-value attribute, and data-sort-type for table header cells (for columns).
gerritbot added a comment.Feb 1 2016, 7:28 PM

Change 267538 merged by jenkins-bot:
Add controls for wikitable and sortable to table dialog

https://gerrit.wikimedia.org/r/267538

Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.Feb 3 2016, 10:39 PM
matmarex reopened this task as Open.Feb 8 2016, 3:34 PM
matmarex subscribed.

The sortable styling patch was reverted in cbe1910f8719fd01ca902810ae9ab73b1256549a (https://gerrit.wikimedia.org/r/#/c/269114/) due to T126007.

I think VE will need to implement some of the tablesorter logic to display the sortable table headings the same as in read mode.

matmarex mentioned this in T126007: Sortable tables with row scope headers or multi-row table head have incorrect sorting icons.Feb 8 2016, 3:35 PM
gerritbot added a comment.Feb 8 2016, 4:12 PM

Change 269153 had a related patch set uploaded (by Esanders):
Provide approximate preview of table sort styling

https://gerrit.wikimedia.org/r/269153

gerritbot added a project: Patch-For-Review.Feb 8 2016, 4:12 PM
Jdforrester-WMF closed this task as Resolved.Apr 3 2016, 12:40 PM
Jdforrester-WMF subscribed.
In T95189#2007962, @matmarex wrote:

The sortable styling patch was reverted in cbe1910f8719fd01ca902810ae9ab73b1256549a (https://gerrit.wikimedia.org/r/#/c/269114/) due to T126007.

Re-closing; this task is about being able to add it, not see it.

Jdforrester-WMF mentioned this in T139072: There should be a visual indication that setting a table's properties to 'sortable' worked.Jul 26 2016, 7:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits