Page MenuHomePhabricator

ORES Failed to process datasource.lower ("object has no attribute 'lower'")
Closed, ResolvedPublicPRODUCTION ERROR

Description

All ORES requests are failing for nlwiki with this error:

     "error": {
       "message": "AttributeError: Failed to process datasource.lower_case(<english.informals.revision.parent.matches>):
'NoneType' object has no attribute 'lower'\nTraceback (most recent call last):\n
 File \"/srv/deployment/ores/venv/lib/python3.4/site-packages/revscoring/dependencies/functions.py\", line 244, in _solve\n    value = dependent(*args)\n
 File \"/srv/deployment/ores/venv/lib/python3.4/site-packages/revscoring/dependencies/dependent.py\", line 52, in __call__\n    return self.process(*args, **kwargs)\n
 File \"/srv/deployment/ores/venv/lib/python3.4/site-packages/revscoring/datasources/meta/mappers.py\", line 35, in process\n    return [self.apply(item) for item in items]\n
 File \"/srv/deployment/ores/venv/lib/python3.4/site-packages/revscoring/datasources/meta/mappers.py\", line 35, in <listcomp>\n    return [self.apply(item) for item in items]\n
 File \"/srv/deployment/ores/venv/lib/python3.4/site-packages/revscoring/datasources/meta/mappers.py\", line 54, in lower\n    return s.lower()\nAttributeError: 'NoneType' object has no attribute 'lower'\n",
       "type": "CaughtDependencyError"
     }
   }

Example:

Affects v1 and v2, both in labs and in production.

Event Timeline

Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)
Legoktm triaged this task as Unbreak Now! priority.Jul 12 2016, 6:34 AM
Legoktm added a subscriber: Legoktm.

This is also spamming exception.log

This one would fix it: https://github.com/wiki-ai/editquality/commit/e3d5a1d9a2ba06f66a608fea328685e8a2d4c7cd

I will make some modifications and push this into beta. I do it for prod tonight.

https://ores-beta.wmflabs.org/scores/nlwiki/?models=damaging&revids=47071016

In beta works now. It's easy to go to prod but I need to talk to @Halfak first. I'm going to deploy it in labs

With the deployment of f472f65 in prod. It's resolved now :) \o/

I will re-open this before the meeting :)

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM