Page MenuHomePhabricator
Create Task
Maniphest T140346

Gallery mode "packed-hover" should show image description in print mode
Closed, ResolvedPublic
Actions

Description

The gallery mode "packed-hover" does not show the image description in browser print mode.

Example: https://test.wikipedia.org/wiki/User:Raymond/packed-hover

https://test.wikipedia.org/w/index.php?title=User:Raymond/packed-hover&printable=yes

I suggest to add some rules to print.css so that the descriptions are visible on printed paper.

Details

SubjectRepoBranchLines +/-
Add print styles for gallery mode packed-hovermediawiki/coremaster+29 -5
Customize query in gerrit

Event Timeline

Raymond created this task.Jul 14 2016, 10:25 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 14 2016, 10:25 AM
MBinder_WMF added a project: Multimedia.Aug 7 2017, 5:38 PM
dr0ptp4kt triaged this task as Low priority.Sep 6 2017, 4:24 PM
dr0ptp4kt added a project: good first task.
dr0ptp4kt moved this task from Untriaged to Needs Design on the Multimedia board.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptSep 6 2017, 4:24 PM
dr0ptp4kt added a project: Design.Sep 6 2017, 4:24 PM
Cparle subscribed.Sep 25 2017, 10:13 AM
gerritbot subscribed.Sep 25 2017, 2:10 PM

Change 380514 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/core@master] Add print styles for gallery mode packed-hover

https://gerrit.wikimedia.org/r/380514

gerritbot added a project: Patch-For-Review.Sep 25 2017, 2:10 PM
Cparle removed a project: Design.Sep 25 2017, 2:20 PM
Cparle added a project: Multimedia-Team-Working-Board.Sep 25 2017, 2:22 PM
Cparle moved this task from To Do to Code Review on the Multimedia-Team-Working-Board board.
matthiasmullie assigned this task to Cparle.Sep 25 2017, 4:16 PM
MarkTraceur moved this task from Code Review to Needs QA on the Multimedia-Team-Working-Board board.Sep 25 2017, 7:40 PM
gerritbot added a comment.Sep 25 2017, 7:49 PM

Change 380514 merged by jenkins-bot:
[mediawiki/core@master] Add print styles for gallery mode packed-hover

https://gerrit.wikimedia.org/r/380514

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 25 2017, 8:00 PM
Cparle added a comment.Oct 11 2017, 10:38 AM

@Raymond patch for this merged and released to beta. Could you take a look please? https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:CParle&printable=yes

Raymond added a comment.Oct 11 2017, 12:50 PM
In T140346#3675009, @Cparle wrote:

@Raymond patch for this merged and released to beta. Could you take a look please? https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:CParle&printable=yes

@Cparle Looks good, thank you :-)

Cparle added a comment.Oct 11 2017, 12:52 PM

\o/ you're welcome!

Cparle closed this task as Resolved.Oct 24 2017, 8:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL