Page MenuHomePhabricator
Create Task
Maniphest T140602

Wrong curid for history link in watchlist for category changes with wpusenewrc enabled
Closed, ResolvedPublic
Actions

Description

On my watchlist with wpusenewrc enabled the following part is shown:

watched category change with wrong curid in history link.png (158×1 px, 27 KB)

The link Versionsgeschichte links to https://de.wikipedia.org/w/index.php?title=Kategorie:Wikipedia:Seite_mit_problematischem_HTML-Tag&curid=581439&action=history The curid is the id of https://de.wikipedia.org/w/index.php?title=Maria_Plain&action=history

Expected result: https://de.wikipedia.org/w/index.php?title=Kategorie:Wikipedia:Seite_mit_problematischem_HTML-Tag&curid=9522202&action=history or https://de.wikipedia.org/w/index.php?title=Kategorie:Wikipedia:Seite_mit_problematischem_HTML-Tag&action=history

Related Objects
Search...

Event Timeline

Fomafix created this task.Jul 18 2016, 11:19 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 18 2016, 11:19 AM
Fomafix added a subtask: T140915: Remove curid parameter from history links on watch list and recent changes.Jul 20 2016, 4:20 PM
Aklapper removed a project: Phlogiston-Category.Aug 11 2016, 11:23 AM
Fomafix mentioned this in T147770: Wrong diff link in watchlist for category changes with wpusenewrc enabled.Oct 10 2016, 4:40 AM
Fomafix added a project: MediaWiki-Recent-changes.Oct 17 2016, 7:55 PM
matej_suchanek added a project: CatWatch.Jan 29 2017, 12:33 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJan 29 2017, 12:33 PM
Tobi_WMDE_SW moved this task from Incoming to CatWatch on the TCB-Team (now WMDE-TechWish) board.Feb 6 2017, 10:53 AM
Fomafix closed subtask T140915: Remove curid parameter from history links on watch list and recent changes as Declined.Jun 5 2017, 9:25 PM
Aklapper mentioned this in T224450: Rename #Category to #Phlogiston-Category.Aug 21 2019, 11:58 PM
Nardog subscribed.EditedDec 21 2020, 11:28 PM

It seems this has been quietly resolved. Now categories with grouped changes are followed only by the plain text "(n changes)", no "history" link. Can someone identify the commit that implemented this change and close this task?

However, wrong curids still appear in permalinks (timestamps) in collapsed lines.

Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 21 2020, 11:28 PM
thiemowmde subscribed.Dec 23 2020, 8:39 AM

The relevant line of code that hides the wrong "history" link is this one here: https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/changes/EnhancedChangesList.php$595. It exists since 2016. Nothing changed, as far as I can see.

I suggest to close this ticket and open a new one for the wrong curid in collapsed lines.

thiemowmde merged a task: T147770: Wrong diff link in watchlist for category changes with wpusenewrc enabled.Dec 23 2020, 8:41 AM
thiemowmde added a subscriber: Swpb.
Nardog closed this task as Resolved.EditedDec 23 2020, 4:40 PM

@thiemowmde Alright, created T270774: Wrong curid and title (tooltip) in grouped category changes on Watchlist/RecentChanges.

T147770 wasn't really a duplicate, by the way, because that one was about diff links and this one history links. But both tasks indeed seem to have been squashed by the same change nevertheless.

It's weird you say it was fixed in 2016. I thought I'd seen those broken diff and history links just months ago, or my brain is failing me.

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL